Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Invalid date filter applied on FIM details flyout #7160

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Nov 14, 2024

Description

This PR solves the problem when applying a date type filter by clicking on the fields of the FIM details flyout.
This problem only occurred in Firefox and Safari browsers.

Closes #7146

Before

Screen.Recording.2024-11-12.at.11.55.18.AM.mov
Screenshot 2024-11-12 at 11 56 08 AM

After

Chrome

Screen.Recording.2024-11-14.at.11.24.02.AM.mov

Safari

Screen.Recording.2024-11-14.at.11.24.48.AM.mov

Firefox

Screen.Recording.2024-11-14.at.11.26.37.AM.mov

Test

  1. Go to File Integrity Monitoring > Inventory Tab
  2. Select an Agent
  3. Click on the File table row
  4. Apply the date filter by clicking the add filter button in the header time field
  5. Repeat test for Safari, Chrome and Firefox browsers

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl changed the title Fix Invalid date filter applied on FIM Details Fixed Invalid date filter applied on FIM Details Nov 14, 2024
@Machi3mfl Machi3mfl changed the title Fixed Invalid date filter applied on FIM Details Fixed Invalid date filter applied on FIM details flyout Nov 14, 2024
@Machi3mfl Machi3mfl linked an issue Nov 14, 2024 that may be closed by this pull request
yenienserrano
yenienserrano previously approved these changes Nov 14, 2024
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Safari

Screen.Recording.2024-11-14.at.5.30.18.PM.mov

Firefox

Screen.Recording.2024-11-14.at.5.34.58.PM.mov

CHANGELOG.md Outdated Show resolved Hide resolved
asteriscos
asteriscos previously approved these changes Nov 14, 2024
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Firefox

Peek 2024-11-14 17-53

yenienserrano
yenienserrano previously approved these changes Nov 14, 2024
@asteriscos asteriscos dismissed stale reviews from yenienserrano and themself via 17cdb00 November 14, 2024 17:00
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.94% ( 4445 / 29751 )
Branches 9.8% ( 1887 / 19250 )
Functions 14.7% ( 1057 / 7186 )
Lines 15.15% ( 4339 / 28624 )

@asteriscos asteriscos merged commit 9641e81 into 4.10.0 Nov 14, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/7146-invalid-date-fim-details-filters branch November 14, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply datetime filters on FIM details returns invalid date
4 participants