-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Invalid date filter applied on FIM details flyout #7160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machi3mfl
changed the title
Fix Invalid date filter applied on FIM Details
Fixed Invalid date filter applied on FIM Details
Nov 14, 2024
Machi3mfl
changed the title
Fixed Invalid date filter applied on FIM Details
Fixed Invalid date filter applied on FIM details flyout
Nov 14, 2024
plugins/main/public/components/agents/fim/inventory/fileDetail.tsx
Outdated
Show resolved
Hide resolved
plugins/main/public/components/agents/fim/inventory/fileDetail.tsx
Outdated
Show resolved
Hide resolved
yenienserrano
previously approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Safari
Screen.Recording.2024-11-14.at.5.30.18.PM.mov
Firefox
Screen.Recording.2024-11-14.at.5.34.58.PM.mov
asteriscos
requested changes
Nov 14, 2024
asteriscos
previously approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yenienserrano
previously approved these changes
Nov 14, 2024
asteriscos
dismissed stale reviews from yenienserrano and themself
via
November 14, 2024 17:00
17cdb00
|
|
|
asteriscos
approved these changes
Nov 14, 2024
yenienserrano
approved these changes
Nov 14, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the problem when applying a date type filter by clicking on the fields of the FIM details flyout.
This problem only occurred in Firefox and Safari browsers.
Closes #7146
Before
Screen.Recording.2024-11-12.at.11.55.18.AM.mov
After
Chrome
Screen.Recording.2024-11-14.at.11.24.02.AM.mov
Safari
Screen.Recording.2024-11-14.at.11.24.48.AM.mov
Firefox
Screen.Recording.2024-11-14.at.11.26.37.AM.mov
Test
Check List
yarn test:jest