Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change agents summary no results #7041

Merged
merged 11 commits into from
Oct 2, 2024
Merged

Change agents summary no results #7041

merged 11 commits into from
Oct 2, 2024

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Oct 1, 2024 •
edited
Loading

Description

Agent summary feature: when there are no agents, we want to hide the graph and show a message and a button indicating the user how to deploy an agent

Issues Resolved

Evidence

image

Test

  • Check overview with and without agents

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz self-assigned this Oct 1, 2024
@JuanGarriuz JuanGarriuz mentioned this pull request Oct 1, 2024
Closed
6 tasks
@guidomodarelli guidomodarelli linked an issue Oct 1, 2024 that may be closed by this pull request
Improve the overview page #7027
Closed
6 tasks
guidomodarelli
guidomodarelli reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEST 🟢
image

plugins/main/public/controllers/overview/components/stats.js Show resolved Hide resolved
plugins/main/public/controllers/overview/components/__snapshots__/stats.test.tsx.snap Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

asteriscos
asteriscos approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Main plugin code coverage (Jest) test % values
Statements 14.09% ( 4177 / 29637 )
Branches 9.22% ( 1779 / 19293 )
Functions 13.74% ( 985 / 7166 )
Lines 14.28% ( 4075 / 28523 )

@asteriscos asteriscos merged commit b6cca95 into 4.10.0 Oct 2, 2024
5 checks passed
@asteriscos asteriscos deleted the enhacement/7027-change-agents-summary-no-results branch October 2, 2024 15:46
@asteriscos asteriscos mentioned this pull request Oct 21, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@guidomodarelli guidomodarelli Awaiting requested review from guidomodarelli

Assignees

@JuanGarriuz JuanGarriuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the overview page
3 participants
@JuanGarriuz @asteriscos @guidomodarelli