Changed step 3 in the "Deploy a new agent" section. #5416

chantal-kelm · 2023-05-03T18:41:07Z

Description

Changed the title of step 3 of the deploy a new agent section:

"Optionally, assign a name and a group to the agent"

By:

"Optional settings"

Added a title to the agent name input of the deploy a new agent section:

"Assign an agent name"

Changed the description of step 3 of the deploy a new agent section:

"The agent name is set as the name of the host where it is deployed. You can set your own name in the field below. Note that the agent name cannot be changed once registered."

By:

"The deployment sets the endpoint hostname as the agent name by default. Optionally, you can set the agent name below."

Changed the placeholder of the agent name input of the deploy a new agent section:

"Name agent"

To:

"Agent name"

Added callout below the agent name entry of the deploy a new agent section:

Captura de pantalla 2023-05-10 a la(s) 10 07 07

Issues Resolved

#5415

Evidence

Captura de pantalla 2023-05-10 a la(s) 12 22 02

Test

Verify that these changes appear:

Changed the title of step 3 of the deploy a new agent section:

"Optionally, assign a name and a group to the agent"

By:

"Optional settings"

Added a title to the agent name input of the deploy a new agent section:

"Assign an agent name"

Changed the description of step 3 of the deploy a new agent section:

"The agent name is set as the name of the host where it is deployed. You can set your own name in the field below. Note that the agent name cannot be changed once registered."

By:

"The deployment sets the endpoint hostname as the agent name by default. Optionally, you can set the agent name below."

Changed the placeholder of the agent name input of the deploy a new agent section:

"Name agent"

To:

"Agent name"

Added callout below the agent name entry of the deploy a new agent section:

Check List

All tests pass
- yarn test:jest
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

… to agent in the deploy new agent section

yenienserrano

Test: ✅
CR: ✅

…ction

github-actions · 2023-05-29T15:46:24Z

Code coverage (Jest)	%	values
Statements	8.78%	( 3244 / 36928 )
Branches	4.48%	( 1285 / 28635 )
Functions	7.63%	( 698 / 9147 )
Lines	8.84%	( 3129 / 35362 )

asteriscos

LGTM ✔️

github-actions · 2023-05-29T17:16:24Z

The backport to 4.4-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-5416-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b573bdc747ab323222e11561b1f4e29e2ad73753
# Push it to GitHub
git push --set-upstream origin backport-5416-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16

Then, create a pull request where the base branch is 4.4-7.16 and the compare/head branch is backport-5416-to-4.4-7.16.

github-actions · 2023-05-29T17:16:25Z

The backport to 4.4-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.10 4.4-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.10
# Create a new branch
git switch --create backport-5416-to-4.4-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b573bdc747ab323222e11561b1f4e29e2ad73753
# Push it to GitHub
git push --set-upstream origin backport-5416-to-4.4-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.10

Then, create a pull request where the base branch is 4.4-7.10 and the compare/head branch is backport-5416-to-4.4-7.10.

* Changes in title and description of step assignment of name and group to agent in the deploy new agent section * Update changelog * Update changelog * Update changelog * Update changelog * Update changelog * Update CHANGELOG.md * sentences were changed and added in step 3 of the deploy new agent section * changelog * changelog * Changed the description of step 3 of the deploy a new agent section. --------- Co-authored-by: Álex Ruiz <[email protected]> (cherry picked from commit b573bdc)

Desvelao · 2023-05-30T13:44:47Z

public/controllers/agent/components/register-agent.js

    }

    systemSelectorWazuhControlMacos() {
      if (this.state.selectedVersion == 'sierra') {
-        return 'sudo /Library/Ossec/bin/wazuh-control start';
-      } else return '';
+        return '/Library/Ossec/bin/wazuh-control start';


nitpick: This command needs to be run with sudo. We should create another pull request or add the commit to fix this in the development branch 4.4 because this pull request was merged with the problem.

…n. (#5513) * Changed step 3 in the "Deploy a new agent" section. (#5416) * Changes in title and description of step assignment of name and group to agent in the deploy new agent section * Update changelog * Update changelog * Update changelog * Update changelog * Update changelog * Update CHANGELOG.md * sentences were changed and added in step 3 of the deploy new agent section * changelog * changelog * Changed the description of step 3 of the deploy a new agent section. --------- Co-authored-by: Álex Ruiz <[email protected]> (cherry picked from commit b573bdc) * Update with sudo register-agent.js

…n. (#5512) * Changed step 3 in the "Deploy a new agent" section. (#5416) * Changes in title and description of step assignment of name and group to agent in the deploy new agent section * Update changelog * Update changelog * Update changelog * Update changelog * Update changelog * Update CHANGELOG.md * sentences were changed and added in step 3 of the deploy new agent section * changelog * changelog * Changed the description of step 3 of the deploy a new agent section. --------- Co-authored-by: Álex Ruiz <[email protected]> (cherry picked from commit b573bdc) * Update with sudo register-agent.js

Changes in title and description of step assignment of name and group…

2277e96

… to agent in the deploy new agent section

chantal-kelm requested a review from a team as a code owner May 3, 2023 18:41

chantal-kelm added backport 4.4-7.16 labels May 3, 2023

chantal-kelm linked an issue May 3, 2023 that may be closed by this pull request

Agent deploy page - optional steps #5415

Closed

chantal-kelm self-assigned this May 3, 2023

chantal-kelm changed the title ~~Changes in title and description of step assignment of name and group…~~ Agent-deploy-page-optional-steps May 3, 2023

yenienserrano previously approved these changes May 4, 2023

View reviewed changes

Machi3mfl previously approved these changes May 4, 2023

View reviewed changes

Update changelog

777e342

chantal-kelm dismissed stale reviews from Machi3mfl and yenienserrano via 777e342 May 4, 2023 17:29

Update changelog

b1f3a00

Machi3mfl previously approved these changes May 4, 2023

View reviewed changes

chantal-kelm dismissed Machi3mfl’s stale review via 7f7b870 May 5, 2023 10:19

Update changelog

7f7b870

chantal-kelm changed the title ~~Agent-deploy-page-optional-steps~~ Agent deploy page optional steps May 5, 2023

chantal-kelm changed the title ~~Agent deploy page optional steps~~ Changed the title and added a description to step 3 of the deploy a new agent section. May 5, 2023

chantal-kelm added 2 commits May 5, 2023 12:09

Update changelog

db3e251

Update changelog

91abf45

Machi3mfl previously approved these changes May 5, 2023

View reviewed changes

yenienserrano previously approved these changes May 5, 2023

View reviewed changes

AlexRuiz7 changed the title ~~Changed the title and added a description to step 3 of the deploy a new agent section.~~ Changed the title and added a description to step 3 of the deploy a new agent section May 5, 2023

Update CHANGELOG.md

196bbfd

AlexRuiz7 dismissed stale reviews from yenienserrano and Machi3mfl via 196bbfd May 5, 2023 16:08

chantal-kelm added 3 commits May 10, 2023 12:05

sentences were changed and added in step 3 of the deploy new agent se…

6b64fbb

…ction

changelog

cb6e691

changelog

4807729

chantal-kelm changed the title ~~Changed the title and added a description to step 3 of the deploy a new agent section~~ Changed step 3 in the "Deploy a new agent" section. May 10, 2023

Changed the description of step 3 of the deploy a new agent section.

bf523aa

Machi3mfl previously approved these changes May 11, 2023

View reviewed changes

Merge branch '4.4' into 5415-Agent-deploy-page-optional-steps

6b956dc

yenienserrano previously approved these changes May 11, 2023

View reviewed changes

resolve conflicts

285ed79

chantal-kelm dismissed stale reviews from yenienserrano and Machi3mfl via 285ed79 May 29, 2023 15:41

Machi3mfl approved these changes May 29, 2023

View reviewed changes

asteriscos approved these changes May 29, 2023

View reviewed changes

asteriscos merged commit b573bdc into 4.4 May 29, 2023

asteriscos deleted the 5415-Agent-deploy-page-optional-steps branch May 29, 2023 17:16

chantal-kelm mentioned this pull request May 30, 2023

Changed step 3 in the "Deploy a new agent" section. (#5416) #5509

Closed

This was referenced May 30, 2023

[Backport 4.4-7.16] Changed step 3 in the "Deploy a new agent" section. #5512

Merged

[Backport 4.4-7.10] Changed step 3 in the "Deploy a new agent" section. #5513

Merged

Desvelao reviewed May 30, 2023

View reviewed changes

asteriscos mentioned this pull request Jun 6, 2023

Release 4.4.4 - Release Candidate 1 - Wazuh UI regression testing #5533

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed step 3 in the "Deploy a new agent" section. #5416

Changed step 3 in the "Deploy a new agent" section. #5416

chantal-kelm commented May 3, 2023 •

edited

Loading

yenienserrano left a comment

github-actions bot commented May 29, 2023

asteriscos left a comment

github-actions bot commented May 29, 2023

github-actions bot commented May 29, 2023

Desvelao May 30, 2023

asteriscos May 30, 2023

Changed step 3 in the "Deploy a new agent" section. #5416

Changed step 3 in the "Deploy a new agent" section. #5416

Conversation

chantal-kelm commented May 3, 2023 • edited Loading

Description

Changed the title of step 3 of the deploy a new agent section:

By:

Added a title to the agent name input of the deploy a new agent section:

Changed the description of step 3 of the deploy a new agent section:

By:

Changed the placeholder of the agent name input of the deploy a new agent section:

To:

Added callout below the agent name entry of the deploy a new agent section:

Issues Resolved

Evidence

Test

Verify that these changes appear:

Changed the title of step 3 of the deploy a new agent section:

By:

Added a title to the agent name input of the deploy a new agent section:

Changed the description of step 3 of the deploy a new agent section:

By:

Changed the placeholder of the agent name input of the deploy a new agent section:

To:

Added callout below the agent name entry of the deploy a new agent section:

Check List

yenienserrano left a comment

Choose a reason for hiding this comment

github-actions bot commented May 29, 2023

asteriscos left a comment

Choose a reason for hiding this comment

github-actions bot commented May 29, 2023

github-actions bot commented May 29, 2023

Desvelao May 30, 2023

Choose a reason for hiding this comment

asteriscos May 30, 2023

Choose a reason for hiding this comment

chantal-kelm commented May 3, 2023 •

edited

Loading