Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 4.5-7.10] Add rel="noopener noreferrer" in documentation links #5271

Merged
merged 2 commits into from
Mar 8, 2023
Merged

[Backport 4.5-7.10] Add rel="noopener noreferrer" in documentation links #5271

merged 2 commits into from
Mar 8, 2023

Conversation

yenienserrano
Copy link
Member

Backport 39d75a7 from #5197.

@yenienserrano
Add rel="noopener noreferrer" in documentation links (#5197)
52b313f 
* add rel="noopener noreferrer"

* add changelog

* edit changelog

---------

Co-authored-by: Álex Ruiz <[email protected]>
(cherry picked from commit 39d75a7)
@yenienserrano yenienserrano requested a review from a team as a code owner March 8, 2023 12:41
@yenienserrano yenienserrano linked an issue Mar 8, 2023 that may be closed by this pull request
Use rel="noopener noreferrer" in documentation links #5038
Closed
8 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Code coverage (Jest) % values
Statements 8.86% ( 3277 / 36999 )
Branches 4.53% ( 1302 / 28744 )
Functions 7.73% ( 708 / 9164 )
Lines 8.92% ( 3160 / 35429 )

Tostti
Tostti approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wazuh dashboard

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Check the value of attributes in changed anchors containing noopener noreferer ⚫ 🟢 ⚫

Details

🟢 Check the value of attributes in changed anchors containing noopener noreferer

Chrome - ⚫

Firefox - 🟢
imagen
imagen

Safari - ⚫

TEST:✔️
CR:✔️

LGTM

asteriscos
asteriscos approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Screenshots

Screenshot from 2023-03-08 17-19-51

Screenshot from 2023-03-08 17-18-06

Screenshot from 2023-03-08 17-12-39

Screenshot from 2023-03-08 17-11-30

Screenshot from 2023-03-08 17-09-41

asteriscos
asteriscos requested changes Mar 8, 2023
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ❌

There are a few external links that still don't have the noreferrer noopener attributes:

Screenshots

Screenshot from 2023-03-08 17-47-15

Screenshot from 2023-03-08 17-37-22

Screenshot from 2023-03-08 17-34-31

Screenshot from 2023-03-08 17-31-01

asteriscos
asteriscos approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining changes will be added in a new pull request

@yenienserrano yenienserrano merged commit df752de into 4.5-7.10 Mar 8, 2023
@yenienserrano yenienserrano deleted the backport-5197-to-4.5-7.10 branch March 8, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tostti Tostti Tostti approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use rel="noopener noreferrer" in documentation links
3 participants
@yenienserrano @asteriscos @Tostti