-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 4.5-7.16] Fix cannot read null properties bug in settings section #5216
Conversation
* fixed bug cannot read null properties in settings section * changelog (cherry picked from commit 4c113f7)
Kibana 7.16.3Legend: UI
Details 🟢 Error is not displayed when going from Settings/Configuration to another sectionSafari - ⚫ 🟢 Platform loading indicator is displayed when saving the configuration in Settings/ConfigurationChrome - 🟢 I was researching this and seems they added a delay time to prevent the uneccessary loadings. Pull request: elastic/kibana#78879 I tried to increase the time to updating the plugin configuration through Settings/Configuration and the loading indicator was displayed. So, it seems to be working as expected. Moreover, they did some changes in the loading indicator behavior from Kibana 7.10.2 to Kibana 7.16 After applying a delay in the time to change the loading indicator status: For another hand, this feature is only presentational and I think it is not a desired functionality. This could be removed in the future if we agree. Firefox - ⚫ Safari - ⚫ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review
🟢 code
🟢 test #5216 (comment)
The loading indicator when saving the plugin configuration through Settings/Configuration could not be displayed if the time of updating the plugin configuration is lower than 250ms. It is due to in change included in the plugin platform. See the test details in #5216 (comment) for more informaiton. |
|
Kibana 7.16.3Legend: UI
Details 🟢 Error is not displayed when going from Settings/Configuration to another sectionChrome - 🟢 Firefox - 🟢 Safari - ⚫ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport 4c113f7 from #5135.