Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 4.4-2.4-wzd] Fixed Inventory checks table filters by stats (#4999) #5005

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Dec 19, 2022

Description

Backport from #4999

Issues Resolved

Closes #4952

Evidence

image
image
image

Test

  1. Scenario The user can add a filter by clicking on the result count indicator (Pass) of the Security configuration assessment
    policy checks
    Given SCA data is available
    When the user is seeing the table of checks of a Security configuration assessment
    policy
    And the user clicks on any result count indicator
    Then a filter must be added to the search bar
    And the table should be filtered by the added filter

  2. Scenario The user can add a filter by clicking on the result count indicator (Fail) of the Security configuration assessment
    policy checks
    Given SCA data is available
    When the user is seeing the table of checks of a Security configuration assessment
    policy
    And the user clicks on any result count indicator
    Then a filter must be added to the search bar
    And the table should be filtered by the added filter

  3. Scenario The user can add a filter by clicking on the result count indicator (Not applicable) of the Security configuration assessment
    policy checks
    Given SCA data is available
    When the user is seeing the table of checks of a Security configuration assessment
    policy
    And the user clicks on any result count indicator
    Then a filter must be added to the search bar
    And the table should be filtered by the added filter

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

* Fixed checks table filters by stats

* Updated CHANGELOG

* Fixed no applicable filter

(cherry picked from commit 6e8c942)
@Desvelao Desvelao self-assigned this Dec 19, 2022
@Desvelao Desvelao requested a review from a team as a code owner December 19, 2022 08:59
@Desvelao Desvelao linked an issue Dec 19, 2022 that may be closed by this pull request
yenienserrano
yenienserrano previously approved these changes Dec 19, 2022
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.65% ( 3195 / 36915 )
Branches 4.43% ( 1271 / 28639 )
Functions 7.54% ( 691 / 9158 )
Lines 8.71% ( 3082 / 35346 )

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Evidence

Peek 2022-12-20 11-16

@asteriscos asteriscos merged commit 6f05431 into 4.4-2.4-wzd Dec 20, 2022
@asteriscos asteriscos deleted the backport-4999-to-4.4-2.4-wzd branch December 20, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCA result filters do not work
4 participants