Define the plugin settings schema, add customization of reports #4461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncements in `Settings/Configuration` and add new plugin settings
- Centralize the plugin settings definition
- Define the plugin setting schema definicion
- Adapt the affected section logic to the new schema
- Create services to simplify some tasks related to the settings
- Removed deprecated files
- Add plugin settings validation
- Frontend:
- Add the validation of the value for each type of input form
- Display the validation error
- Hightlight the setting with validation error
- Display the count settings with errors in the bottom save bar
- Disable the save button when there is some validation error
- Backend:
- Add validation of some endpoint parameters
- Changes in `Settings/Configuration`:
- Adapt the components to the new plugin settings definition
- Refactor some components and methods
- Remove not necessary files
- Add new hooks to manage the state of the changed inputs of `Settings/Configuration`
- Add new endpoints to manage the uploading/deletion of files
- Add new settings to customize the header and footer of the PDF reports
- Add new input form of type file picker to upload the images
This was
linked to
issues
Sep 8, 2022
inputs - Add plugin setting validation - Refactor the inputs form - Add new plugin setting to enable or disable the customization - Undone configuration coming from file system - Refactor service to check the existence or create a directory if it is not exist
|
We'll split these changes into multiple PRs. So, we will close this PR in favor to: |
AlexRuiz7
deleted the
feat/refactor-plugin-settings-customize-logos-reports
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4426 #4434 #4443 #4446 #4450
This PR:
customization.reports.header: custom text for the header of the PDF reports.customization.reports.footer: custom text for the footer of the PDF reports.Settings/ConfigurationPUT /utils/configurationPUT /utils/configuration/files/{key}PUT /utils/configuration/files/{key}DELETE /utils/configuration/files/{key}Settings/Configuration