Timeout change in the restart manager in the configuration #4264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desvelao
reviewed
Jun 16, 2022
| @@ -280,6 +280,7 @@ export const restartNodeSelected = async ( | |||
| `Restarting ${isCluster ? selectedNode : 'Manager'}, please wait.` | |||
| ); //FIXME: if it enables/disables cluster, this will show Manager instead node name | |||
| isCluster ? await restartNode(selectedNode) : await restartManager(); | |||
| await delayAsPromise(15000); | |||
There was a problem hiding this comment.
question: why this delay is required?
Desvelao
reviewed
Jun 17, 2022
Desvelao
approved these changes
Jun 17, 2022
Desvelao
reviewed
Jun 17, 2022
public/controllers/management/components/management/configuration/utils/wz-fetch.js
Show resolved
Hide resolved
Desvelao
reviewed
Jun 17, 2022
public/controllers/management/components/management/reporting/utils/reporting-handler.js
Show resolved
Hide resolved
Desvelao
reviewed
Jun 17, 2022
public/controllers/management/components/management/reporting/utils/reporting-handler.js
Show resolved
Hide resolved
Desvelao
reviewed
Jun 17, 2022
Desvelao
reviewed
Jun 17, 2022
public/controllers/management/components/management/configuration/utils/wz-fetch.js
Show resolved
Hide resolved
|
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2022
* fix: timeout change * add changelog * parmeters refractor and format * changelog: replaced PR entry Co-authored-by: Antonio David Gutiérrez <[email protected]> Co-authored-by: Álex <[email protected]> (cherry picked from commit 2f83a43)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2022
* fix: timeout change * add changelog * parmeters refractor and format * changelog: replaced PR entry Co-authored-by: Antonio David Gutiérrez <[email protected]> Co-authored-by: Álex <[email protected]> (cherry picked from commit 2f83a43)
AlexRuiz7
pushed a commit
that referenced
this pull request
Jun 17, 2022
…iguration (#4278) Timeout change in the restart manager in the configuration (#4264) * fix: timeout change * add changelog * parmeters refractor and format * changelog: replaced PR entry Co-authored-by: Antonio David Gutiérrez <[email protected]> Co-authored-by: Álex <[email protected]> (cherry picked from commit 2f83a43) Co-authored-by: Ian Yenien Serrano <[email protected]>
AlexRuiz7
pushed a commit
that referenced
this pull request
Jun 17, 2022
…onfiguration (#4279) Timeout change in the restart manager in the configuration (#4264) * fix: timeout change * add changelog * parmeters refractor and format * changelog: replaced PR entry Co-authored-by: Antonio David Gutiérrez <[email protected]> Co-authored-by: Álex <[email protected]> (cherry picked from commit 2f83a43) Co-authored-by: Ian Yenien Serrano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added the waiting time to see if the manager is active again since it was not waiting for anything and in other ways of restarting it waits for 15000ms
Issue:
Preconditions:
Test:
Screenshot:
restartManager.mp4