Fixed code editor component height in logs layout (Management and Settings) #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machi3mfl
added
type/bug
Desvelao
requested changes
Jun 14, 2022
yenienserrano
approved these changes
Jun 14, 2022
Machi3mfl
changed the title
chantal-kelm
approved these changes
Jun 16, 2022
|
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2022
…tings) (#4253) * Fixed management logs layout * Added dynamic offset * Updated CHANGELOG * Fixed offset calculation depends on height screen * Used calc in overflow height in codeblock * Added calc in settings logs * changelog: replaced PR entry Co-authored-by: Antonio David Gutiérrez <[email protected]> (cherry picked from commit b7eed0b)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2022
…tings) (#4253) * Fixed management logs layout * Added dynamic offset * Updated CHANGELOG * Fixed offset calculation depends on height screen * Used calc in overflow height in codeblock * Added calc in settings logs * changelog: replaced PR entry Co-authored-by: Antonio David Gutiérrez <[email protected]> (cherry picked from commit b7eed0b)
AlexRuiz7
pushed a commit
that referenced
this pull request
Jun 17, 2022
… (Management and Settings) (#4273) Fixed code editor component height in logs layout (Management and Settings) (#4253) * Fixed management logs layout * Added dynamic offset * Updated CHANGELOG * Fixed offset calculation depends on height screen * Used calc in overflow height in codeblock * Added calc in settings logs * changelog: replaced PR entry Co-authored-by: Antonio David Gutiérrez <[email protected]> (cherry picked from commit b7eed0b) Co-authored-by: Maximiliano Ibarra <[email protected]>
AlexRuiz7
pushed a commit
that referenced
this pull request
Jun 17, 2022
…out (Management and Settings) (#4274) Fixed code editor component height in logs layout (Management and Settings) (#4253) * Fixed management logs layout * Added dynamic offset * Updated CHANGELOG * Fixed offset calculation depends on height screen * Used calc in overflow height in codeblock * Added calc in settings logs * changelog: replaced PR entry Co-authored-by: Antonio David Gutiérrez <[email protected]> (cherry picked from commit b7eed0b) Co-authored-by: Maximiliano Ibarra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
This PR fixes a Management > Logs layout to ensure that the "Load more logs" show correctly.
Closes #4206