-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple filters change between panel and drilldown panel #3568
Simple filters change between panel and drilldown panel #3568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only comment I think would block this PR is the type for the new prop in useSuggestedValues. The rest are either suggestions or questions for curiosity's sake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: LGTM ✔️
Test: LGTM ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi guys,
In this PR we try to change the simple filters between the vies of Panel and the view of Drilldown Panel (selecting a row in Panel)
To test it, go to GitHub Panel, see the Simple filters allocated there, then select a row and check if the filters have changed. Of course, only some of these rows have to change. Do more than 1 attempt.
Example:
Panel view:
Drilldown view:
Closes #3563