Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0-7.9] Fixed search filter in search bar in Module/SCA wasn't working #2601

Merged
merged 3 commits into from
Nov 6, 2020
Merged

[4.0-7.9] Fixed search filter in search bar in Module/SCA wasn't working #2601

merged 3 commits into from
Nov 6, 2020

Conversation

frankeros
Copy link
Contributor

Hi team! This resolves

  • Search filter in the search bar in Module/SCA wasn't working

Related to #2460

@Desvelao
fix(frontend): search filter in search bar in Module/SCA wasn't working
28f5a49 
Let search in string or number fields with the search term
@frankeros frankeros added this to the Sprint 119 milestone Nov 6, 2020
@frankeros frankeros self-assigned this Nov 6, 2020
@frankeros frankeros requested a review from jsanchez91 November 6, 2020 15:12
jsanchez91
jsanchez91 approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@jsanchez91 jsanchez91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsanchez91 jsanchez91 merged commit 200302e into 4.0-7.9 Nov 6, 2020
@jsanchez91 jsanchez91 deleted the 4.0-7.9-fix-sca-checks branch November 6, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsanchez91 jsanchez91 jsanchez91 approved these changes

Assignees

@frankeros frankeros

Labels
None yet
Projects
None yet
Milestone
Sprint 119
Development

Successfully merging this pull request may close these issues.
3 participants
@frankeros @jsanchez91 @Desvelao