Navbar hide flick

[adri9valle]

Hi team,

This PR makes that the wz-menu directive does not hide while changing between views. Also, it adds the Wazuh logo into the Kibana navbar.

Solves: #1502

Regards,

[jesusgn90]

Here are some points that must be corrected:

• Take care of indentation, spaces, and the IDE linter, most of your PRs @juankaromo and @adri9valle have a lot of changes just for the spaces. Examples: https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-4fb0e45f4ba6881335591c2d8331b72bR77, https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-4fb0e45f4ba6881335591c2d8331b72bR168-R170
• I'm not sure about the changes in https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-68b7eb0a46906f69251595b3de59d82fR19, https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-0827b748e21358097b2d5c055e1fd4a4R277, and https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-e1d8afa12b7757b6a5a0e5ca39603ad6R409, are they tested in Chrome, Safari, Firefox, and Edge? style changes not always work on all the common browsers.
• What about this change https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-6da88186b15de66e0019d2c444b83f38R1 ? is it really needed?
• What's the reason for adding a new logo.svg https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-5ba5f6ff3433ed6aa2238ea0acf26c62R1 ? is not enough with the current logos? why?
• The image https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-06ae65c0838ae3124c509b009c18bf1b was there from 3.10 or it was there from 3.9.x? why?
• Removing ng-init from https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-e292650419113230f327da5d80f7c3afR1 for example (there are more places) would result in an empty value for the very first time, fix it, please.
• Using hardcoded width for a table is not a good practice, please use flex or dynamic attributes https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-3c857f34cabc19eb9d9865d9090852f9R6
• Using EUI classes as it is not a good practice, why are you using three spans instead of a EUI badge or something similar? https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-3c857f34cabc19eb9d9865d9090852f9R14, more examples: https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-00e601050723ff11f74bb32af032b08bR18, https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-71114d420284b6575b22ae590fc9bd67R17, https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-c0b1fd637a5e40cba0beb86f10977521R6
• 500ms is too big IMO, https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-7bc1a3385dc3c43388f730f3f2f7977cR22, why not just 100ms? Is it expected to always found the element, right?
• This should not be here https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-f27ce2293e2536876f25022f99593f95R254-R258, it's a commented code block, remove it, please.
• The registry file should not be here, https://github.com/wazuh/wazuh-kibana-app/pull/1558/files#diff-db60ff377bde0b07913b7343c7172999R1, remove it, please.

[juankaromo]

Hi @jesusgn90 I'm going to clarify the points above:

• Indentation, spaces, and the IDE linter It seems that there is a problem with my prettier version. It's updated, but he keeps doing weird things.

• Style The main change is to adapt the menu to be outside of the main container, and, on the other hand, keep it fixed, to improve the UX. Maybe this needs another review on more browsers.

• Logos The Wazuh logos have been updated to adapt them to the new corporative blue color.

• Removed image This image was added to show it when 'No SCA results' message was shown. But it has been deprecated.

• Empty value for the very first time That was fixed here 0f4cbeb

• Using EUI classes It was removed finally.

• 500ms is too big The interval time has been reduced to 100ms 0f4cbeb

• Commented code block and removing wazuh-version.json Fixed here 0f4cbeb