Remove processes state column in macOS agents (#7122)

* Refactor process column mapping to use a dedicated function for improved readability and maintainability * Update CHANGELOG to document removal of processes state column in macOS agents (#7122) * Refactor process column mapping to use `mapColumns` for consistency across OS implementations and enhance code clarity * Remove unused 'State' column from inventory snapshot for better clarity in agent rendering tests
wazuh · Oct 24, 2024 · e74b7ed · e74b7ed
1 parent 9157e9a
commit e74b7ed
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 31 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -42,6 +42,7 @@ All notable changes to the Wazuh app project will be documented in this file.
 - Removed agent RBAC filters from dashboard queries [#6945](https://github.com/wazuh/wazuh-dashboard-plugins/pull/6945)
 - Removed GET /elastic/statistics API endpoint [#7001](https://github.com/wazuh/wazuh-dashboard-plugins/pull/7001)
 - Removed VirusTotal application in favor of Malware Detection [#7038](https://github.com/wazuh/wazuh-dashboard-plugins/pull/7038)
+- Removed processes state column in macOS agents [#7122](https://github.com/wazuh/wazuh-dashboard-plugins/pull/7122)
 
 ## Wazuh v4.9.1 - OpenSearch Dashboards 2.13.0 - Revision 04
 

diff --git a/plugins/main/public/components/agents/syscollector/__snapshots__/inventory.test.tsx.snap b/plugins/main/public/components/agents/syscollector/__snapshots__/inventory.test.tsx.snap
@@ -2085,31 +2085,6 @@ exports[`Inventory component A Apple agent should be well rendered. 1`] = `
                           </span>
                         </button>
                       </th>
-                      <th
-                        aria-live="polite"
-                        aria-sort="none"
-                        class="euiTableHeaderCell"
-                        data-test-subj="tableHeaderCell_state_6"
-                        role="columnheader"
-                        scope="col"
-                        style="width:15%"
-                      >
-                        <button
-                          class="euiTableHeaderButton"
-                          data-test-subj="tableHeaderSortButton"
-                          type="button"
-                        >
-                          <span
-                            class="euiTableCellContent"
-                          >
-                            <span
-                              class="euiTableCellContent__text"
-                            >
-                              State
-                            </span>
-                          </span>
-                        </button>
-                      </th>
                     </tr>
                   </thead>
                   <tbody>
@@ -2118,7 +2093,7 @@ exports[`Inventory component A Apple agent should be well rendered. 1`] = `
                     >
                       <td
                         class="euiTableRowCell euiTableRowCell--isMobileFullWidth"
-                        colspan="7"
+                        colspan="6"
                       >
                         <div
                           class="euiTableCellContent euiTableCellContent--alignCenter"

diff --git a/plugins/main/public/components/agents/syscollector/columns/process-columns.ts b/plugins/main/public/components/agents/syscollector/columns/process-columns.ts
@@ -1,4 +1,10 @@
-import { KeyEquivalence } from "../../../../../common/csv-key-equivalence";
+import { KeyEquivalence } from '../../../../../common/csv-key-equivalence';
+
+const mapColumns = ({ field, ...rest }: { field: string; name?: string }) => ({
+  ...rest,
+  field,
+  name: rest.name || KeyEquivalence[field] || field,
+});
 
 const windowsColumns = [
   { field: 'name', searchable: true, sortable: true, width: '10%' },
@@ -8,7 +14,8 @@ const windowsColumns = [
   { field: 'priority', searchable: true, sortable: true },
   { field: 'nlwp', searchable: true, sortable: true },
   { field: 'cmd', searchable: true, sortable: true, width: '30%' },
-].map(({field, ...rest}) => ({...rest, field, name: rest.name || KeyEquivalence[field] || field}));
+].map(mapColumns);
+
 const linuxColumns = [
   { field: 'name', searchable: true, sortable: true, width: '10%' },
   { field: 'euser', searchable: true, sortable: true },
@@ -22,16 +29,16 @@ const linuxColumns = [
   { field: 'session', searchable: true, sortable: true },
   { field: 'nice', searchable: true, sortable: true },
   { field: 'state', searchable: true, sortable: true, width: '15%' },
-].map(({field, ...rest}) => ({...rest, field, name: rest.name || KeyEquivalence[field] || field}));
+].map(mapColumns);
+
 const macColumns = [
   { field: 'name', searchable: true, sortable: true, width: '10%' },
   { field: 'euser', searchable: true, sortable: true },
   { field: 'pid', searchable: true, sortable: true },
   { field: 'ppid', searchable: true, sortable: true },
   { field: 'vm_size', searchable: true, sortable: true },
   { field: 'nice', searchable: true, sortable: true },
-  { field: 'state', searchable: true, sortable: true, width: '15%' },
-].map(({field, ...rest}) => ({...rest, field, name: rest.name || KeyEquivalence[field] || field}));
+].map(mapColumns);
 
 export const processColumns = {
   windows: windowsColumns,