Add rel="noopener noreferrer" in documentation links (#5197)

* add rel="noopener noreferrer" * add changelog * edit changelog --------- Co-authored-by: Álex Ruiz <[email protected]> (cherry picked from commit 39d75a7)
wazuh · Mar 8, 2023 · 27d09eb · 27d09eb
1 parent 547327a
commit 27d09eb
Show file tree

Hide file tree

Showing 8 changed files with 49 additions and 17 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,7 +6,7 @@ All notable changes to the Wazuh app project will be documented in this file.
 
 ### Added
 
--
+- Added rel="noopener noreferrer" in documentation links. [#5197](https://github.com/wazuh/wazuh-kibana-app/pull/5197)
 
 ### Changed
 

diff --git a/public/components/agents/syscollector/inventory.tsx b/public/components/agents/syscollector/inventory.tsx
@@ -42,6 +42,7 @@ export function SyscollectorInventory({ agent }) {
                 'user-manual/agents/agent-connection.html',
               )}
               target='_blank'
+              rel='noopener noreferrer'
             >
               Checking connection with the Wazuh server
             </a>

diff --git a/public/components/common/modules/discover/row-details.tsx b/public/components/common/modules/discover/row-details.tsx
@@ -457,12 +457,20 @@ export class RowDetails extends Component {
       let name = "";
 
       value.forEach(item => {
-        if (item.type === 'cve')
+        if (item.type === 'cve'){
           name = item.name;
-        if (item.type === 'link')
-          link = <a href={item.name} target="_blank">{item.name}</a>
-      })
-      return <span>{name}: {link}</span>
+        }
+        if (item.type === 'link') {
+          link = <a
+            href={item.name}
+            target="_blank"
+            rel="noopener noreferrer"
+          >
+            {item.name}
+          </a>;
+        }
+      });
+      return <span>{name}: {link}</span>;
     } else {
       const _value = typeof value === 'string' ? value : this.getValueAsString(value);
       return (
@@ -545,7 +553,11 @@ export class RowDetails extends Component {
                 </EuiTitle>
               }
               extraAction={
-                <a href={`#/manager/rules?tab=rules&redirectRule=${id}`} target="_blank" style={{ paddingTop: 5 }}>
+                <a
+                  href={`#/manager/rules?tab=rules&redirectRule=${id}`}
+                  target="_blank" style={{ paddingTop: 5 }}
+                  rel="noopener noreferrer"
+                >
                   <EuiIcon type="popout" color='primary' />&nbsp;
                   View in Rules
                 </a>

diff --git a/public/components/common/welcome/agents-welcome.js b/public/components/common/welcome/agents-welcome.js
@@ -531,7 +531,11 @@ class AgentsWelcome extends Component {
               <p>
                 The agent has been registered but has not yet connected to the manager.
             </p>
-              <a href={webDocumentationLink('user-manual/agents/agent-connection.html')} target="_blank">
+              <a
+                href={webDocumentationLink('user-manual/agents/agent-connection.html')}
+                target="_blank"
+                rel="noopener noreferrer"
+              >
                 Checking connection with the Wazuh server
               </a>
             </Fragment>

diff --git a/public/controllers/agent/components/register-agent.js b/public/controllers/agent/components/register-agent.js
@@ -1027,7 +1027,7 @@ apk add wazuh-agent=${this.state.wazuhVersion}-r1`,
           <a
             href={urlCheckConnectionDocumentation}
             target='_blank'
-            rel='noreferrer'
+            rel="noopener noreferrer"
           >
             document.
           </a>
@@ -1666,7 +1666,7 @@ apk add wazuh-agent=${this.state.wazuhVersion}-r1`,
             serverAddress: nodeSelected,
             udpProtocol: this.state.haveUdpProtocol,
             connectionSecure: this.state.haveConnectionSecure
-          }); 
+          });
       };
 
       const steps = [

diff --git a/public/controllers/management/components/management/configuration/configuration-no-agent.js b/public/controllers/management/components/management/configuration/configuration-no-agent.js
@@ -26,7 +26,11 @@ export const WzAgentNeverConnectedPrompt = () => (
         <p>
           The agent has been registered but has not yet connected to the manager.
         </p>
-        <a href={documentationLink} target="_blank">
+        <a
+          href={documentationLink}
+          target="_blank"
+          rel="noopener noreferrer"
+        >
           Checking connection with the Wazuh server
         </a>
       </Fragment>
@@ -36,4 +40,4 @@ export const WzAgentNeverConnectedPrompt = () => (
         Back
       </EuiButton>
   }
-  />)
+  />)
diff --git a/public/controllers/management/components/management/ruleset/views/rule-info.tsx b/public/controllers/management/components/management/ruleset/views/rule-info.tsx
@@ -220,7 +220,7 @@ export default class WzRuleInfo extends Component {
     const badgeList = [];
     const fields = ['pci_dss', 'gpg13', 'hipaa', 'gdpr', 'nist_800_53', 'tsc', 'mitre'];
     const buildBadge = (field) => {
-      
+
       return (
         <EuiToolTip content={item[field].join(', ')} key={`${item.id}-${field}`} position="bottom">
           <EuiBadge
@@ -348,13 +348,20 @@ export default class WzRuleInfo extends Component {
       let name = '';
 
       value.forEach((item) => {
-        if (item.type === 'cve') name = item.name;
-        if (item.type === 'link')
+        if (item.type === 'cve'){
+          name = item.name;
+        }
+        if (item.type === 'link'){
           link = (
-            <a href={item.name} target="_blank">
+            <a
+              href={item.name}
+              target="_blank"
+              rel="noopener noreferrer"
+            >
               {item.name}
             </a>
           );
+        }
       });
       return (
         <span>

diff --git a/public/utils/check-plugin-version.tsx b/public/utils/check-plugin-version.tsx
@@ -70,7 +70,11 @@ const checkClientAppVersion = (appInfo: TAppInfo) => {
         <p>If the error persists, restart {PLUGIN_PLATFORM_NAME} as well.</p>
         <p>
           For more information check our troubleshooting section{' '}
-          <a href={troubleshootingUrl} target="_blank">
+          <a
+            href={troubleshootingUrl}
+            target="_blank"
+            rel="noopener noreferrer"
+          >
             here.
           </a>
         </p>
-Original file line number
+Diff line change
@@ Expand Up @@
     ### Added
-    -
+    - Added rel="noopener noreferrer" in documentation links. [#5197](https://github.com/wazuh/wazuh-kibana-app/pull/5197)
     ### Changed
@@ Expand Down @@