Let the agent's CLI key option be optional #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdvendramini
force-pushed
the
enhancement/246-let-the-agents-cli-key-option-be-optional
branch
from
d99b6fb
to
a325035
Compare
TomasTurina
reviewed
Oct 29, 2024
TomasTurina
reviewed
Oct 29, 2024
TomasTurina
reviewed
Oct 29, 2024
TomasTurina
reviewed
Oct 29, 2024
sdvendramini
force-pushed
the
enhancement/246-let-the-agents-cli-key-option-be-optional
branch
2 times, most recently
from
5f9f0ea
to
f826438
Compare
sdvendramini
force-pushed
the
enhancement/246-let-the-agents-cli-key-option-be-optional
branch
from
f826438
to
2efdee4
Compare
vikman90
changed the title
vikman90
requested changes
Oct 30, 2024
There was a problem hiding this comment.
@sdvendramini Please don't forget to add the tests corresponding to the new CreateKey() and ValidateKey() methods.
sdvendramini
force-pushed
the
enhancement/246-let-the-agents-cli-key-option-be-optional
branch
from
8949276
to
d871cbc
Compare
jr0me
reviewed
Oct 30, 2024
jr0me
reviewed
Oct 30, 2024
jr0me
reviewed
Oct 30, 2024
jr0me
reviewed
Oct 30, 2024
sdvendramini
force-pushed
the
enhancement/246-let-the-agents-cli-key-option-be-optional
branch
4 times, most recently
from
af94a7a
to
43449e8
Compare
TomasTurina
approved these changes
Oct 31, 2024
sdvendramini
force-pushed
the
enhancement/246-let-the-agents-cli-key-option-be-optional
branch
from
43449e8
to
6c0d648
Compare
vikman90
approved these changes
Oct 31, 2024
The inclusion of fmt as a public library in the Logger is removed and it is added as a private library in the agent.
Two functions were added to create and validate a key during the agent registration process. Additionally, the --key argument is now optional.
sdvendramini
force-pushed
the
enhancement/246-let-the-agents-cli-key-option-be-optional
branch
3 times, most recently
from
91c0880
to
476fedb
Compare
Some tests added to the AgentRegistration and AgentInfo classes, and others fixed due to previous changes.
sdvendramini
force-pushed
the
enhancement/246-let-the-agents-cli-key-option-be-optional
branch
from
476fedb
to
8714716
Compare
TomasTurina
approved these changes
Oct 31, 2024
TomasTurina
deleted the
enhancement/246-let-the-agents-cli-key-option-be-optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With these changes, the key can now be automatically generated if not provided, making the
--keyargument optional during agent registration process. Also if the key is provided, is validated to ensure it is 32 alphanumeric characters.