V4 dev #1
Open
V4 dev #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Ubuntu, our native font-stack doesn't output the same font on Firefox and Chrome. This is [a known aliasing issue](http://fontfamily.io/sans-serif) — check at the bottom, Ubuntu 14.04. Ubuntu 18.04 (my current) doesn't use the same (Firefox uses Liberation Sans, Chrome uses the default system font Ubuntu). I'm inclined to prefer Liberation Sans since it's closer to Arial / Helvetica. This patch already exists in Boosted, didn't notice it was missing in bootstrap until today… BTW, our linked Smashing Magazine's system fonts post mentions this and is even more accurate since it targets the three major Linux distributions. AFAIK this is not needed since [Liberation Sans is available everywhere](http://fontfamily.io/Liberation_Sans) — but we might go back to `Oxygen, Ubuntu, Cantarell`if we want to stick to system fonts. Co-authored-by: XhmikosR <[email protected]>
This should make the build error out if there are any issues instead of emitting a warning, which we won't notice.
* Suppress flexbox side effects * Trailing whitesapce Co-authored-by: Mark Otto <[email protected]> Co-authored-by: XhmikosR <[email protected]>
Should run on PRs too.
This basically brings back the previous behavior we had on Travis CI, where if the commit message included `[ci skip]`, BrowserStack tests didn't run. Additionally, this allows skipping BrowserStack if the commit message contains `[skip ci]` too.
* Fix form validation tooltip alignment * Remove CSS hacks * Update _forms.scss Co-authored-by: Gaël Poupard <[email protected]> Co-authored-by: XhmikosR <[email protected]>
Also, reword Node.js setup step
* Update Edge's Rendering Engine on CONTRIBUTING.md Also updated the URL to prevent a HTTP redirect. * Add 'Go to "Help > Send Feedback" from the browser' note Co-authored-by: XhmikosR <[email protected]>
* autoprefixer ^9.8.6 → ^10.0.1 * find-unused-sass-variables ^2.0.0 → ^3.0.0 * linkinator ^2.2.0 → ^2.2.2 * postcss-cli ^7.1.2 → ^8.2.0
* Make docs anchorjs links darker on keyboard focus Not just on mouse hover * Update site/assets/scss/_anchor.scss Co-authored-by: Mark Otto <[email protected]> Co-authored-by: Mark Otto <[email protected]>
Co-authored-by: XhmikosR <[email protected]>
* @babel/cli ^7.16.0 → ^7.16.7 * @babel/core ^7.16.5 → ^7.16.7 * @babel/preset-env ^7.16.5 → ^7.16.7 * @rollup/plugin-node-resolve ^13.1.1 → ^13.1.2 * autoprefixer ^10.4.0 → ^10.4.1 * eslint ^8.4.1 → ^8.6.0 * eslint-plugin-import ^2.25.3 → ^2.25.4 * eslint-plugin-qunit ^7.1.0 → ^7.2.0 * eslint-plugin-unicorn ^39.0.0 → ^40.0.0 * hugo-bin ^0.78.1 → ^0.79.2 * linkinator ^2.16.2 → ^3.0.3 * node-sass ^7.0.0 → ^7.0.1 * rollup ^2.61.1 → ^2.63.0 * stylelint ^14.1.0 → ^14.2.0 * stylelint-config-twbs-bootstrap ^3.0.0 → ^3.0.1 Also, remove the unused glob package.
This is a backport from BS5 to BS4. As per #35553 The ```small-font -size``` will actually increase from ```13px``` to ```14px``` with this proposed change. Personally I'd prefer keeping it the BS5 way (```14px```), as the text is more readable now. If it's needed, I can do another PR with the ```$small-font-size: .8125rem !default;``` to resemble BS4 more closely but I feel like this would be a move forward even for BS4.
* Move linkinator to GitHub Actions. * Remove `docs-linkinator` npm script since it's no longer used
* Manually backport 32630 Dynamic tabs: use buttons rather than links * Tweak unit test * Tweak unit tests * More tweakage * show() should also bail if `disabled` attribute is set * Tweak tests * Simplify test for relatedTarget * Temporarily remove problematic test (as i can't get local tests to run just noww) * Revert previous * test: fix broken test cases for tab.js * test: fix role=tablist invalid on nav element * test: prefer <div/> over <div></div> * Manually backport 32630 Dynamic tabs: use buttons rather than links * test: fix broken test cases for tab.js * Fixes * Remove and ignore lock file Co-authored-by: alpadev <[email protected]> Co-authored-by: Mark Otto <[email protected]> Co-authored-by: Mark Otto <[email protected]>
- add `sr-only` "Bootstrap", which will be part of the accessible name - extra `sr-only` text to give some context - that the dropdown is about switching versions - remove the redundant id/aria-labelledby for the dropdown - change the control from `<a>` to `<button>`
* eslint ^8.16.0 → ^8.17.0 * hugo-bin ^0.87.1 → ^0.88.2 * rollup ^2.74.1 → ^2.75.6 * stylelint-config-twbs-bootstrap ^3.1.0 → ^4.0.0 * stylelint ^14.8.5 → ^14.9.0 * terser ^5.13.1 → ^5.14.0
* @babel/cli ^7.17.10 → ^7.18.6 * @babel/core ^7.18.2 → ^7.18.6 * @babel/preset-env ^7.18.2 → ^7.18.6 * @rollup/plugin-commonjs ^22.0.0 → ^22.0.1 * eslint ^8.17.0 → ^8.19.0 * eslint-plugin-qunit ^7.2.0 → ^7.3.1 * hugo-bin ^0.88.2 → ^0.89.0 * karma ^6.3.20 → ^6.4.0 * lockfile-lint ^4.7.4 → ^4.7.6 * nodemon ^2.0.16 → ^2.0.19 * postcss-cli ^9.1.0 → ^10.0.0 * rollup ^2.75.6 → ^2.76.0 * stylelint ^14.9.0 → ^14.9.1 * terser ^5.14.0 → ^5.14.1
* Bump version to 4.6.2. * Dist
Update authors and copyright to match npm, add repository reference. Also incorporates licensing expression change by @vanillajonathan (#37378) Co-authored-by: Jesse Mandel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge into this branch