Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover #5

Closed
gregoriopellegrino opened this issue Jun 29, 2022 · 9 comments
Closed

Cover #5

gregoriopellegrino opened this issue Jun 29, 2022 · 9 comments

Comments

@gregoriopellegrino
Copy link
Collaborator

gregoriopellegrino commented Jun 29, 2022

Knowledge base reference: http://kb.daisy.org/publishing/docs/epub/cover.html

Export setup

In the EPUB export wizard, in the General tab we set Cover as "Rasterise First Page" or "Choose Image" (and selecting an image file):
Schermata 2022-06-29 alle 11 44 47
Schermata 2022-06-29 alle 11 44 58

Issue

With these export settings we get the cover.xhtml file containing the <img> tag with a non significant alt attribute:

<img src="image/cover.png" alt="cover.png" style="max-width:100%;" />

How to fix it

Allow the user to set an appropriate alternative text for the cover image (maybe in the export wizard). Maybe placeholder based on metadata Cover of [title] by [author] may help the user.

Other improvements

To improve the accessibility the cover page, you can enrich the semantics by using DPUB Aria roles in the HTML role attribute. In the file 3-enriched-semantics.epub we have made a proposal for enriched semantics.

gregoriopellegrino added a commit that referenced this issue Jun 29, 2022
as described in issue #5
@CircularKen
Copy link

CircularKen commented Jun 30, 2022

The default placeholder text could be derived from the Publication Language - GitHub #6

@LauraB7
Copy link
Collaborator

LauraB7 commented Mar 8, 2023

User story: "As a screen reader user I can hear the relevant information included on the cover image."

@raman211
Copy link

raman211 commented Jan 31, 2024

Hi @gregoriopellegrino @ways2read @CircularKen @LauraB7,

This is Ramanjulu from Adobe,

Please confirm Whether the following proposed UX allows the content creator to add the required alternative text for the cover image only for the Reflowable workflow.
We are thinking of two possible designs (We would like to have your thoughts shared on these)

  1. without the checkbox (means mandating the alternative text )
    AltTextFieldForCoverImage

  2. With the checkbox, to allow the user to declare it as a decorative image or not

Screenshot 2024-02-05 at 5 36 50 PM

We are thinking, that the option 2 should address the HTML role attribute case also.

Please also confirm if any changes are required for the Fixed Layout case.

Thanks,
Ramanjulu.

@LauraB7
Copy link
Collaborator

LauraB7 commented Feb 6, 2024

Hello @raman211. The second screenshot is the closest to the implementation that we'd like, with some caveats.

  • No checkbox, please.
  • The cover image will never need to be marked as decorative.
  • Suggested auto-populated text: "Cover: [title] by [author]. Description of image."

Additionally, it would be great if the resulting HTML was in a <figure> tag and had no inline styling (style="max-width:100%;").

Finally, we would like time to test this before it's implemented to all InDesign users.

@raman211
Copy link

raman211 commented Feb 6, 2024

@LauraB7 Thanks a lot for the early feedback, we would love to share a pre-release build with the above suggestions incorporated.

@raman211
Copy link

raman211 commented Mar 26, 2024

Hi @gregoriopellegrino @ways2read @LauraB7 @CircularKen,

The feature is available in the latest InDesign PreRelease of 19.4
Looking forward to your valuable feedback, before releasing it in 19.4
Please share your feedback on it ASAP, so that we can accommodate the changes for the 19.4 release.

Thanks,
Ramanjulu.

@gregoriopellegrino
Copy link
Collaborator Author

Dear @raman211,
here is our feedback:

  • the text put in the field for alt-text is not a placeholder, but is real text, so the user has to delete it before typing (not convenient)
    • If Indesign can only manage real text in the field (not a placeholder), the field should be left empty by default, as is the object export options alt text field
  • the text you've put in the field for the alt-text as a placeholder is different from the text we suggested in previous comment Cover #5 (comment)
  • If the user does not enter anything in the field, the alt attribute should be left empty
    • right now it is exported "Cover Image"

@gregoriopellegrino
Copy link
Collaborator Author

Another thing (cited in comment #5 (comment)): to improve the accessibility the cover page, you can enrich the semantics by using DPUB Aria roles in the HTML role attribute, in particular role="doc-cover" on the <img> tag.

@gregoriopellegrino
Copy link
Collaborator Author

gregoriopellegrino commented Jun 11, 2024

Dear @raman211,
to prepare ourselves for the call scheduled on Monday, June 17th: are there any new updates or releases related to this issue (specifically #5 (comment) and #5 (comment))?

Currently, we are running the InDesign Pre-Release 19.5 (Mainline CI #f95bd09) version on our machines.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants