Skip to content

Commit

Permalink
Merge pull request #72 from waynestate/ckeditor-version-4.20.0
Browse files Browse the repository at this point in the history
update ckeditor4 from v4.19.1 to v4.20.0
  • Loading branch information
chrispelzer authored Nov 3, 2022
2 parents 9bb09c8 + 52644da commit 87d45e0
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ You can install the package into a Laravel application that uses [Nova](https://
composer require waynestate/nova-ckeditor4-field
```

By default the CKEditor 4 instance used is the latest (4.19.1) Full All version (https://cdn.ckeditor.com/). If you wish to use a different CKEditor 4 you can do so by publishing and editing the configuration.
By default the CKEditor 4 instance used is the latest (4.20.0) Full All version (https://cdn.ckeditor.com/). If you wish to use a different CKEditor 4 you can do so by publishing and editing the configuration.

## Usage

Expand Down
12 changes: 12 additions & 0 deletions UPGRADING.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## From v1.1.4 to v1.2.0

### Migrations
Added support for Laravel loadMigrationsFrom to allow for migrations to be handled without needing to publish them.

Previous versions the migration was being published with the timestamp of the time of publishing which caused multiple migrations to be published.
Expand All @@ -19,3 +20,14 @@ If this is the case, you will need to manually delete the migrations that were p
```php
php artisan vendor:publish --tag=nova-ckeditor4-field-migrations
```

### CKEditor version
Updated the CKEditor4 version from 4.19.1 to 4.20.0 as the default version.
You can review the changes at https://github.com/ckeditor/ckeditor4-releases/blob/master/CHANGES.md#ckeditor-420

If you have a published config and wish to use the new version, you will need to update the `ckeditor_url` option within your published `/config/nova/ckeditor-field.php`.
```php
'ckeditor' => [
'ckeditor_url' => 'https://cdn.ckeditor.com/4.20.0/full-all/ckeditor.js',
],
```
2 changes: 1 addition & 1 deletion config/ckeditor-field.php
Original file line number Diff line number Diff line change
Expand Up @@ -84,5 +84,5 @@
| CKEditor 4 is only supported. This will not work with CKEditor 5
|
*/
'ckeditor_url' => 'https://cdn.ckeditor.com/4.19.1/full-all/ckeditor.js',
'ckeditor_url' => 'https://cdn.ckeditor.com/4.20.0/full-all/ckeditor.js',
];
2 changes: 1 addition & 1 deletion dist/js/field.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion resources/js/components/CKEditor.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default {
},
editorUrl: {
type: String,
default: 'https://cdn.ckeditor.com/4.19.1/full-all/ckeditor.js'
default: 'https://cdn.ckeditor.com/4.20.0/full-all/ckeditor.js'
},
config: {
type: Object,
Expand Down
2 changes: 1 addition & 1 deletion src/CKEditor4FieldServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public function boot()
});

Nova::serving(function (ServingNova $event) {
Nova::script('ckeditor', config('nova.ckeditor-field.ckeditor_url', 'https://cdn.ckeditor.com/4.19.1/full-all/ckeditor.js'));
Nova::script('ckeditor', config('nova.ckeditor-field.ckeditor_url', 'https://cdn.ckeditor.com/4.20.0/full-all/ckeditor.js'));

Nova::script('nova-ckeditor', __DIR__ . '/../dist/js/field.js');
// Nova::style('nova-ckeditor', __DIR__ . '/../dist/css/field.css');
Expand Down

0 comments on commit 87d45e0

Please sign in to comment.