Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: build improvements #247

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Feat: build improvements #247

merged 1 commit into from
Feb 3, 2021

Conversation

patzm
Copy link
Contributor

@patzm patzm commented Feb 2, 2021

I had a brief look at the 🐳 docker based build setup. I found it a bit weird that the Docker-based approach would pull from the remote. For me, this would have made iterative work very cumbersome (push everytime I change someting). Also, any external contributor (like me) would need to change the base url of the GitHub repo (which external contributors have to fork).

Instead, it might be much easier to simply copy the current state of the repository into the docker container. The .gitignore prevents that unnecessary and maybe sensitive information from git finds its way there.

I also changed the folder name for the generated outputs to artifacts. Just an idea, reverting is simple.

@google-cla
Copy link

google-cla bot commented Feb 2, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@patzm
Copy link
Contributor Author

patzm commented Feb 2, 2021

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Feb 2, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@patzm
Copy link
Contributor Author

patzm commented Feb 2, 2021

@googlebot I fixed it.

@peisun1115 peisun1115 merged commit 96fb728 into waymo-research:master Feb 3, 2021
@patzm patzm deleted the feat/build branch February 3, 2021 11:28
peisun1115 added a commit that referenced this pull request Mar 5, 2021
peisun1115 added a commit that referenced this pull request Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants