Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a brief look at the 🐳 docker based build setup. I found it a bit weird that the Docker-based approach would pull from the remote. For me, this would have made iterative work very cumbersome (push everytime I change someting). Also, any external contributor (like me) would need to change the base url of the GitHub repo (which external contributors have to fork).
Instead, it might be much easier to simply copy the current state of the repository into the docker container. The
.gitignore
prevents that unnecessary and maybe sensitive information fromgit
finds its way there.I also changed the folder name for the generated outputs to
artifacts
. Just an idea, reverting is simple.