Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation with changes in freeze-feat #116

Merged

Conversation

CheerfulPianissimo
Copy link

No description provided.

@CheerfulPianissimo
Copy link
Author

Presently --slurp requires some value to go along with it. So a simple region selection command will need an empty string to be passed along: wayshot -s "" which seems pretty clunky to me. Is it fine if I make SLURP_ARGS optional, so that wayshot -s also works @Shinyzenith ?

@uncomfyhalomacro
Copy link

i have a feeling that slurp arg should be of Option. if None, we can just have -s. i guess i should PR for such a small change later

@CheerfulPianissimo
Copy link
Author

I have already implemented the change @uncomfyhalomacro , should I include it in this PR?

@uncomfyhalomacro
Copy link

it would be much appreciated @CheerfulPianissimo

@CheerfulPianissimo CheerfulPianissimo marked this pull request as ready for review May 23, 2024 08:39
@CheerfulPianissimo
Copy link
Author

alright, the manpages have been updated to reflect the cli changes. Please inform me if I've missed anything @Shinyzenith

@Shinyzenith
Copy link
Member

@CheerfulPianissimo Hi sooraj, lets schedule a call as this pr will need to be interlaced with a few more. When are you available?

@CheerfulPianissimo
Copy link
Author

Anytime this week will be fine.

@Shinyzenith
Copy link
Member

I want to merge this as part of your pr, is this updated? @CheerfulPianissimo

@CheerfulPianissimo
Copy link
Author

This PR doesn't have anything to do with the libwayshot code and no changes have been made to the wayshot CLI so yes it should be up to date.

@Shinyzenith Shinyzenith merged commit 5c3e220 into waycrate:freeze-feat-andreas Aug 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants