Re-emit ignored events from grabbed devices to uinput devices #163
Conversation
|
@EdenQwQ #147 did not work for you at the time. This PR builds on @Shinyzenith's work and should allow mouse movement to work (at least it does on my end). Would you mind taking a look to tell me if it works for you now? |
|
This pr works perfectly for me! |
|
Closes #131 |
|
Great! |
Would be nice if eden took a look too. I think eden is a little busy with university so if they don't respond, we shall go ahead with the merge. |
|
Hi @ajanon, really sorry to bother you but would you mind rebasing this onto main branch? |
ajanon
force-pushed
the
mouse-fix-re-emit
branch
from
c6aa109 to
b1b206c
Compare
|
@Shinyzenith Here you go! |
|
Thank you! |
|
@ajanon Please go ahead and merge this if convenient ❤️ |
Signed-off-by: Shinyzenith <[email protected]>
Signed-off-by: Shinyzenith <[email protected]>
Ignored events (i.e. events other than key presses for now) are re-emitted to the uinput devices. This allows grabbing mouses and other pointer devices while still allowing the cursors to work. In some cases, events are not re-emitted at all when the uinput device handles keys, relative axes and switches. By sending switch events to a separate uinput device just for switches and another one for keys and relative axes, we can re-emit keys, pointer events, and switches events properly.
ajanon
force-pushed
the
mouse-fix-re-emit
branch
from
b1b206c to
a0fba06
Compare
|
I just rebased this onto main, and I will merge it once CI finishes. I also removed Eden from the reviewers as they seem busy. |
|
@Shinyzenith If you could just approve this again so that I can merge it, it would be great! |
|
Pr seems great! Go for the merge. Thank you for the patch ❤️ |
|
I cannot merge on my side, the button is greyed out 😞 |
|
How about now? |
|
Perfect! :) |
|
Reminder to self: push to mirror |
Ignored events (i.e. events other than key presses for now) are re-emitted to the uinput devices. This allows grabbing mouses and other pointer devices while still allowing the cursors to work.
In some cases, events are not re-emitted at all when the uinput device handles keys, relative axes and switches. By sending switch events to a separate uinput device just for switches and another one for keys and relative axes, we can re-emit keys, pointer events, and switches events properly.