Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/convert endpoint broken #89

Closed
macrouch opened this issue Feb 1, 2021 · 12 comments
Closed

/convert endpoint broken #89

macrouch opened this issue Feb 1, 2021 · 12 comments

Comments

@macrouch
Copy link
Contributor

macrouch commented Feb 1, 2021

Both on https://ogre.adc4gis.com/ and using the api call from an app returns the following 400 error when trying to use the /convert endpoint

{"error":true,"msg":"No file provided"}

@abettermap
Copy link

I don't know enough about the changes otherwise I'd take a stab at a PR, but I'm guessing something to do with switching to tmpdir in the recent version change: v2.0.1...v2.1.0

@macrouch
Copy link
Contributor Author

macrouch commented Feb 1, 2021

tmpdir is only used in /convertJson, that endpoint seems to be working (at least on the website), my application doesn't use that endpoint, only /convert

I've been trying to get the code running locally since I filed the issue, I finally got it running but it works locally

@wavded
Copy link
Owner

wavded commented Feb 1, 2021

This may have been due to a recently server upgrade to Node 14 LTS. Do you still experience the issue now? I currently cannot duplicate so I would need more details if you still have an issue.

@macrouch
Copy link
Contributor Author

macrouch commented Feb 1, 2021

I switched my local environment to node 14 lts and it still works locally, but uploading any file to https://ogre.adc4gis.com/ fails

@rcr-usfs
Copy link

rcr-usfs commented Feb 1, 2021

I am still getting this error: {"error":true,"msg":"No file provided"} when using the website as well as the api call. For now, I am just using the geojson and .zip version of the shapefile provided on the website.

macrouch added a commit to macrouch/ogre that referenced this issue Feb 1, 2021
@wavded
Copy link
Owner

wavded commented Feb 1, 2021

Was able to duplicate now and applied a fix. How does it perform now?

@macrouch
Copy link
Contributor Author

macrouch commented Feb 1, 2021

expressjs/connect-multiparty#29

Looks like connect-multiparty had an issue with Node 14 they fixed

@wavded
Copy link
Owner

wavded commented Feb 1, 2021

@macrouch care to open a PR with that change?

@macrouch
Copy link
Contributor Author

macrouch commented Feb 1, 2021

Already did ;)

It is also working for me with whatever change you made

@wavded
Copy link
Owner

wavded commented Feb 1, 2021

Thx @macrouch for the PR and all ya'll for testing.

@wavded wavded closed this as completed Feb 1, 2021
@macrouch
Copy link
Contributor Author

macrouch commented Feb 1, 2021

Thanks for the quick response! Our users thank you!

@rcr-usfs
Copy link

rcr-usfs commented Feb 1, 2021

Works for me now! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants