Updating PluginABCE example to use new ABCE standard formats #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biegelk
changed the title
nstauff
requested changes
May 4, 2023
| @@ -11,41 +11,41 @@ | |||
| from pathlib import Path | |||
There was a problem hiding this comment.
I recommend adding a little bit more description of what sensitivity analysis we are trying to do here. This is a sensitivity analysis where we are scanning a range of peak demand and PTC incentive to determine ???...
| params.show_summary(show_metadata=True, sort_by='key') | ||
| abce_plugin = watts.PluginABCE(f'{template_name}', show_stdout=True, show_stderr=True) | ||
| abce_result = abce_plugin(params, extra_args=['-f']) | ||
| abce_result = abce_plugin(params, extra_args=["-f"]) | ||
|
|
There was a problem hiding this comment.
Would it be possible to extract one or two potential results of interest and print them out?
|
@biegelk let me know if you can wrap up these changes so that we can resolve this PR. If too much effort, then let's disregard them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the ABCE-WATTS example case in
examples/1App_ABCE_C2N. ABCE has undergone a major data format update, and the outdated ABCE input file template in the examples directory was causing the code to break. This PR updates thePluginABCEexample input template to the new ABCE standards, and updateswatts_exec.pyto match.Checklist:
[n/a] I have made corresponding changes to the documentation (if applicable)
[n/a] I have added tests that prove my fix is effective or that my feature works (if applicable)