Add Heroku support #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@watson friendly ping 🙂 |
|
is there any documentation available for this. @jgierer12 .? |
fearphage
suggested changes
Feb 23, 2021
| @@ -12,6 +12,10 @@ Object.defineProperty(exports, '_vendors', { | |||
| exports.name = null | |||
| exports.isPR = null | |||
|
|
|||
| function includes (str, search) { | |||
| return !!~str.indexOf(search) | |||
There was a problem hiding this comment.
Make this less clever and more explicit.
- return !!~str.indexOf(search)
+ return str.indexOf(search) > -1;| { | ||
| "name": "Heroku", | ||
| "constant": "HEROKU", | ||
| "env": { "env": "NODE", "includes": "heroku" } |
There was a problem hiding this comment.
In the test, you check for this value: /app/.heroku/node/bin/node. Is that a constant? Could you check for that value explicitly instead of any value with heroku in it?
|
@sibiraj-s After more than a year without any update, for Heroku support, is it okay for me to create another PR to supersede this? |
|
Thanks @shian15810 PR's always welcome. And it is good to have the approach taken is somewhere documented by Heroku. So it won't break randomly. |
|
Sorry for the long hold. But Closing this in favour of #95. |
sibiraj-s
pushed a commit
that referenced
this pull request
Nov 13, 2022
Based off of the work started in #34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.