fix(package.json): update dependencies to fix vulnerabilities #183
Conversation
|
@apaparazzi0329 We are still using webpack 4 in this PR. Can we get all the dependencies updated including major releases? |
|
Sure |
|
@germanattanasio Does it look ready to go? |
apaparazzi0329
force-pushed
the
dependency-update
branch
from
a0a69d0 to
4834714
Compare
|
Did you test this with the node-sdk and make sure it works in the different browsers? I found that this package it's tricky and there are always issues when testing with firefox or chrome. |
|
Once you confirm that you manually tested this PR then we can merge it |
|
The new commit I pushed passed manual testing for chrome, firefox, and safari |
| "defaults": "^1.0.3", | ||
| "get-user-media-promise": "^1.1.4", | ||
| "ibm-watson": "^5.6.0", | ||
| "ibm-watson": "^6.0.2", |
There was a problem hiding this comment.
Should we make this a feature release since you are doing a major release of the ibm-watson sdk?
There was a problem hiding this comment.
There is a separate issue here asking for a proper 1.0 release of this sdk; however, upgrading to ibm-watson 6.0.2 doesn't actually release any new features to this sdk so I don't think the upgrade itself would justify a feature release
There was a problem hiding this comment.
didn't we drop support for Node <10 in ibm-watson 6.x?
There was a problem hiding this comment.
We did and I can update the package.json to reflect that but I don't see what new features that would give the user in terms of using the sdk and its methods
apaparazzi0329
force-pushed
the
dependency-update
branch
from
c99d7cc to
b120597
Compare
|
🎉 This PR is included in version 0.38.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.