fixing error looping bug

watson-developer-cloud · Nov 1, 2016 · 74aa663 · 74aa663
1 parent cd9432b
commit 74aa663
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 34 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Changelog
 
+### v0.20.4
+* Fix looping error propagation when not using FormatStream in recognizeMicrophone
+
 ### v0.20.3
 * Fixed broken model query param in STT RecognizeStream
 

diff --git a/dist/watson-speech.js b/dist/watson-speech.js
diff --git a/speech-to-text/recognize-microphone.js b/speech-to-text/recognize-microphone.js
@@ -141,17 +141,10 @@ module.exports = function recognizeMicrophone(options) {
 
   }).catch(recognizeStream.emit.bind(recognizeStream, 'error'));
 
-  /**
-   * Propagate error to new FormatStream
-   *
-   * @param {String} error message
-   */
-  function handleError(error) {
-    stream.emit('error', error);
-  }
-
   // Capture error from original RecognizeStream
-  recognizeStream.on('error', handleError);
+  if (stream !== recognizeStream) {
+    recognizeStream.on('error', stream.emit.bind(stream, 'error'));
+  }
 
   return stream;
 };