Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bipolar membrane unit model and costing #1500

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

johnson12742
Copy link

@johnson12742 johnson12742 commented Oct 2, 2024

Fixes/Resolves:

(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)

Summary/Motivation:

Adding the bipolar membrane unit model capability

Changes proposed in this PR:

  • Bipolar Electrodialysis 0-D unit model with a test. Heavily borrows from Electrodialysis 0-D.
  • Documentation for the Bipolar Electrodialysis 0-D unit model
  • Costing package for Bipolar Electrodialysis unit model. This is a slightly modified version of the electrodialysis costing. With bipolar there is a negative cost component (value addition)

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@johnson12742 johnson12742 marked this pull request as ready for review October 3, 2024 00:59
@lbianchi-lbl lbianchi-lbl added the Priority:Normal Normal Priority Issue or PR label Oct 3, 2024
Figure 1. Schematic representation of a bipolar electrodialysis unit


One bipolar membrane along with the **Acidate** and **Basate** channels can thus be treated as a modelling unit that can
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are acidate and basate typical terminology for BPMD?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not. I needed a name for the acid & base channel.
I went off diluted/ concentrated channel which are called diluate/concentrate (in ED documentation). Extrapolating from this I chose acidate/basate.

If anybody has better suggestion I am happy to use it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory they are an acid concentrate and base concentrate (increasing in concentration), where the brine is a brine diluate (deceasing in concentration) based on the donation of ions toward the objective of the system, correct?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they do increase concentration. But I think there is a subtle difference. BPMED increase concentration via production of new acid/base (through water splitting) and not by just transporting ions across the membranes. I feel like that deserved a distinction in nomenclature. Thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with either acid and base or acidic and basic.

Copy link
Author

@johnson12742 johnson12742 Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam-a-a That's reasonable. I have changed the names to Acidic & Basic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants