Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with new installation procedures #36

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

nickrsan
Copy link
Contributor

No description provided.

@AdamJCrawford
Copy link
Member

Do you think we should be more explicit about gdal installation in the installation section of the readme? Ie it is not as simple as python -m pip install eedl if you don't have gdal installed. Might cause confusion for some down the line if they are unfamiliar with gdal.

@nickrsan
Copy link
Contributor Author

Yes, I think you're absolutely right about that. That's a good catch. I'm also going to update this PR with the new license information. Can you think of a reason to go with anything except MIT license? That's my goto, but I'm happy to do something else if you see a reason

@nickrsan
Copy link
Contributor Author

OK @AdamJCrawford when you get a chance, will you take another look? I now mention GDAL before the pip command.

@AdamJCrawford
Copy link
Member

AdamJCrawford commented Oct 23, 2023

Yes, I think you're absolutely right about that. That's a good catch. I'm also going to update this PR with the new license information. Can you think of a reason to go with anything except MIT license? That's my goto, but I'm happy to do something else if you see a reason

I exclusively use MIT unless I'm doing something with other peoples code that isn't MIT

Copy link
Member

@AdamJCrawford AdamJCrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickrsan nickrsan merged commit 985dc9b into main Oct 23, 2023
14 checks passed
@nickrsan nickrsan deleted the readme-install-update branch October 23, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants