Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a point extraction feature to the zonal stats #19

Merged
merged 7 commits into from
Aug 16, 2023

Conversation

nickrsan
Copy link
Contributor

It won't create the centroids for us, but if we have centroids of our own, it will do point extractions instead of zonal stats.

Need a new, functional Python environment to do some testing and additional coding
Also, removing duplicated zonal stats code.
@nickrsan nickrsan requested a review from AdamJCrawford August 16, 2023 22:52
@nickrsan nickrsan self-assigned this Aug 16, 2023
@nickrsan
Copy link
Contributor Author

@AdamJCrawford if you get a chance to look at the files changed here, please do give me feedback. I'm going to merge these for now, but if you have any thoughts on anything I did, I'm interested.

@nickrsan nickrsan merged commit d14e5e6 into release Aug 16, 2023
@AdamJCrawford
Copy link
Member

How do you want to handle the version number in init.py? I noticed you didn't change it for this PR

@AdamJCrawford
Copy link
Member

@nickrsan Not sure if you saw this or not.

@nickrsan
Copy link
Contributor Author

Hey Adam, sorry, I did see it, but hadn't responded - was slowly turning my attention to syncing up code here, but we should be all set to create new branches and not conflict with each other again, etc.

For now, I'm just bumping the version number whenever we think of it - it was missed for this PR, but that's probably OK. In the future, a better system would be nice. Do you know how others handle this in their release process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants