Implement type hints #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickrsan I changed the exception messages, changed how the exceptions are being handled for the export_type check, and added type hintsfor pathlib Path objects |
nickrsan
requested changes
Jun 29, 2023
There was a problem hiding this comment.
Hi Adam, nice work - you did great on everything - the things I had comments about were on things we hadn't discussed (primarily related to PyCharm reformatting the file). Are you willing to make the changes I mention in the comments, or would you prefer I do it myself?
|
@nickrsan Believe I have addressed everything. |
|
Wonderful. Thanks Adam. I'll take a look later tonight or tomorrow |
nickrsan
reviewed
Jun 30, 2023
nickrsan
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type hints to all functions. There are still some parameters that need to be type hinted, but I am unsure of what they are supposed to be.