-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with stack on the back of building with cabal. #515
Conversation
@philderbeast thanks for this, I haven't thought about this option really! Interesting, so this way they can also use Stack, due to resolver being specified (+ additional packages). I had experience offering two different build systems in the past, on my other open source project (https://github.com/Martinsos/edlib), and I have to admit I found it to be hard to maintain. For edlib it was more important though due to CMake being so widely used. With Wasp, I would love us to avoid this situation. I do see that we don't need much to configure Stack, but still we need to make sure to update resolved, add packages, ... . And since it is not in CI, we will forget to do so and it will become broken at some point. Or, if we put it in CI, then we have to think about it every time, and that is also work that I would rather avoid. So for now I would skip doing this, but it is good that we have an idea it can be done, so if we realize in the feature that people actually want/need this, we can reconsider it! |
In case someone is searching this repo for "stack". These are the steps to get going with stack.
Add waspc anyway: # stack.yaml
resolver: lts-18.28
- packages: []
+ packages: [.] Build now fails.
Follow the recommendation. # stack.yaml
resolver: lts-18.28
packages: [.]
+ extra-deps:
+ - dir-traverse-0.2.3.0@sha256:adcc128f201ff95131b15ffe41365dc99c50dc3fa3a910f021521dc734013bfa,2137
+ - path-0.9.2@sha256:2f2a7f01737cd350b30381b619e1a862601c83f10ede4d6935f76f66e63ae0c7,3273
+ - strong-path-1.1.3.0@sha256:6f20e9a9fc39ec359d119bd23a402ed1869653b98224d530645a41fe0ddb9357,2247 Build now works. |
@Martinsos having a |
Thanks @philderbeast ! Ok let's see, maybe we will do it in the future, but for now better to skip it since we don't have the bandwidth. Still, good that we now have some info here in this PR regarding this! |
Description
Even though building with cabal is now preferred some outside contributors might well prefer to build with stack. Now that
waspc.cabal
is committed to source control that is possible. I've not put back thestan
,hlint
orormolu
tool setup nor have I added CI for stack.On the back of the fix for #453.