Enables strict null checks in SDK #2360
Conversation
| @@ -302,7 +302,7 @@ function AdditionalFormFields({ | |||
| disabled={isLoading} | |||
| /> | |||
| {errors[field.name] && ( | |||
| <FormError>{errors[field.name].message}</FormError> | |||
| <FormError>{errors[field.name]!.message}</FormError> | |||
There was a problem hiding this comment.
I'm not sure why this is needed since we have the check errors[field.name] && (?
| @@ -69,7 +69,7 @@ async function getAuthUserData(userId: {= userEntityUpper =}['id']): Promise<Aut | |||
| throwInvalidCredentialsError() | |||
| } | |||
|
|
|||
| return createAuthUserData(user); | |||
| return createAuthUserData(user!); | |||
There was a problem hiding this comment.
Again, I'm not sure why this is needed since we have the check if (!user) {. Maybe it's not obvious to the compiler that the throwInvalidCredentialsError fn throws?
| const { data: task, isLoading } = tasksCrud.get.useQuery({ | ||
| id: parseInt(id, 10), | ||
| }); | ||
| const { id } = useParams<{ id: string }>() |
There was a problem hiding this comment.
Not related to this PR, but a quick fix since id is of type string | undefined.
| @@ -18,7 +18,7 @@ import { | |||
| // Details here: https://github.com/wasp-lang/wasp/issues/2017 | |||
| export function makeQueryCacheKey<Input, Output>( | |||
| query: Query<Input, Output>, | |||
| payload: Input | |||
| payload?: Input | |||
There was a problem hiding this comment.
payload !== undefined hints at payload being optional
| @@ -1,9 +1,9 @@ | |||
| {{={= =}=}} | |||
There was a problem hiding this comment.
I've started to work on enabling strict null checks while working on env variables, so these are some changes I left from that effort - env -> nodeEnv since I imagined that the import of env vars would look like import { env } from 'wasp/server'
| @@ -93,4 +93,5 @@ type ClientOperationWithNonAnyInput<Input, Output> = | |||
| ? (args?: unknown) => Promise<Output> | |||
| : [Input] extends [void] | |||
| ? () => Promise<Output> | |||
| : (args: Input) => Promise<Output> | |||
| // TODO: decide if this is what we want? | |||
| : (args?: Input) => Promise<Output> | |||
There was a problem hiding this comment.
We get the error:
client/operations/hooks.ts(32,26): error TS2345: Argument of type 'Input | undefined' is not assignable to parameter of type 'Input'.
The useQuery hook definition:
function useQuery<Input, Output>(
query: Query<Input, Output>,
queryFnArgs?: Input,
options?: any
): UseQueryResult<Output, Error>has the queryFnArgs as an optional argument: and it executes query(queryFnArgs), query is:
query: Query<Input, Output>which is in the end (args: Input) => Promise<Output>.
This leads me to set the args as optional here.
There was a problem hiding this comment.
@sodic alternativelly, I can just put a @ts-ignore and not modify anything related to operations, so we can deal with this in the future?
infomiho
changed the title
infomiho
force-pushed
the
miho-strict-null-checks
branch
from
18f9fd0
to
a509762
Compare
This PR enables
strictNullChecksoption in the SDKtsconfig.json.We want to enable this option to make sure Zod schemas are working properly before we start using them for env variables validation.
Left to do
@ts-ignoreand a TODO for things that need more workUsing
@ts-ignoreis not that problematic since it will unblock us for using Zod schemas, but also explicitly mark parts of the code base that need some work. This work was still needed before this PR, but it was implicit.