Implement wasp/client/crud API #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infomiho
commented
Jan 30, 2024
| @@ -8,7 +8,7 @@ import type { | |||
| {=# isAuthEnabled =} | |||
| import { throwInvalidCredentialsError } from 'wasp/auth/utils' | |||
| {=/ isAuthEnabled =} | |||
| import type { GetAllQuery, GetQuery, CreateAction, UpdateAction, DeleteAction } from "{= crudTypesImportPath =}"; | |||
| import type { {= crud.name =} } from "wasp/server/crud"; | |||
There was a problem hiding this comment.
New API simplified this import, but this was also a bug that was fixed @Martinsos
infomiho
commented
Jan 30, 2024
| then | ||
| genCrudOperations spec cruds | ||
| <++> genCrudServerOperations spec cruds | ||
| then genCrudServerOperations spec cruds |
There was a problem hiding this comment.
Later on, we should move genCrudServerOperations to Wasp.Generator.SdkGenerator.Server.CrudG as well. I didn't want to make unnecessary changes in this first round of changes.
There was a problem hiding this comment.
Should we drop a comment maybe or you think it will be o obvious enough?
Martinsos
approved these changes
Jan 30, 2024
Martinsos
force-pushed
the
new-sdk-client-crud
branch
from
9cbd817 to
5f7b1f5
Compare
sodic
pushed a commit
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.