-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the project install step #1602
Implement the project install step #1602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did another round!
Done! |
TODO: Update the docs. |
I fixed all the comments except for that one you said @sodic not to touch. |
Ok I actually revived you change to how output in terminal is prefixed, I saw after running it more that it just doesn't look good. |
I also did the docs. I hunted down mentions of dependencies and either removed them if redundant or updated them to talk about |
I tried running I also tried adding a dep directly into |
Everything you mentioned here should be working. |
Important
I messed up the base branch when merging this. The entire discussion is here, but the commit that ended up in main is in this PR: #1690.
Fixes #1597.
Tasks:
wasp start
dependencies
field in.wasp
files - I decided to remove the field and only keep a single source of truth, the `package.json file.How to run and test stuff:
waspc/examples/todo-typescript
and work inside that project../cleanstart
will clean everything, fix known issues (e.g., duplicate react) and start the app with all the necessary migrations applied.cabal run wasp-cli start
,cabal run wasp-cli clean
) will do what you expect.cabal run wasp-cli start
, or run./cleanstart
(depending on what you're changing)../fix
to fix the double react installation issue (but often won't need to, as./cleanstart
takes care of it).package-lock.json
.Important
PR 1603 (
filip-wasp-reset
) branches out of PR 1604 (filip-restructuring-prisma
), which branches out of PR 1602 (filip-project-install-step
).The PR numbers are unfortunately out of order.
Make sure you keep the branches up to date with their bases as you change stuff.