Get rid of std::function in C++ API #615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
noexcept-host-func
branch
3 times, most recently
from
34a2a7f
to
85a73af
Compare
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
==========================================
+ Coverage 98.24% 98.25% +0.01%
==========================================
Files 63 63
Lines 9370 9310 -60
==========================================
- Hits 9206 9148 -58
+ Misses 164 162 -2 |
gumb0
force-pushed
the
noexcept-host-func
branch
2 times, most recently
from
1a34274
to
efa7b9b
Compare
gumb0
force-pushed
the
noexcept-host-func
branch
4 times, most recently
from
7ae65b9
to
ef07548
Compare
|
@gumb0 what is the status of this? Can you rebase and show what is the actually relevant change? |
gumb0
force-pushed
the
noexcept-host-func
branch
from
ef07548
to
64fba47
Compare
|
The entire first commit is minimal needed change. I would close this, because I think it complicates API too much, and currently seems to me not worth to pursue. |
|
Feel free to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.