Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mutable exported global. Fix #137 #227

Conversation

kateinoigakukun
Copy link

@parity-cla-bot
Copy link

It looks like @kateinoigakukun hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@kateinoigakukun
Copy link
Author

[clabot:check]

@parity-cla-bot
Copy link

It looks like @kateinoigakukun signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@NikVolf
Copy link
Contributor

NikVolf commented Jan 3, 2020

worth mentioning that it closes #137

@kateinoigakukun kateinoigakukun force-pushed the katei/mutable-exported-global branch from aa508d7 to 4e028d0 Compare January 6, 2020 12:36
@kateinoigakukun kateinoigakukun changed the title Allow mutable exported global Allow mutable exported global. Fix #137 Jan 6, 2020
@taegyunkim
Copy link
Contributor

Hi @kateinoigakukun, are you sill pursuing this? I'm interested in updating testsuites submodule to HEAD, and can help or take from here on.

For green CI, you have to also update a test in validation subcrate, specifically this one c9f0597

@taegyunkim
Copy link
Contributor

@kateinoigakukun I'll accept your thumbs up as a sign for me to take this.

@pepyakin
Copy link
Collaborator

This PR was superseded by #228. Thanks for the effort anyway @kateinoigakukun !

@pepyakin pepyakin closed this Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants