Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify error handling and restructure runner.rs #1278

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Nov 2, 2024

No description provided.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 77.64706% with 19 lines in your changes missing coverage. Please review.

Project coverage is 81.35%. Comparing base (25a613f) to head (7ad6ba3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/tests/spec/runner.rs 77.64% 19 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1278   +/-   ##
=======================================
  Coverage   81.35%   81.35%           
=======================================
  Files         306      306           
  Lines       25251    25248    -3     
=======================================
- Hits        20543    20541    -2     
+ Misses       4708     4707    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop
Copy link
Member Author

Robbepop commented Nov 2, 2024

The Miri (spec) job experienced a time-out despite the recent increase in time.

@Robbepop Robbepop merged commit c36a741 into main Nov 2, 2024
17 of 19 checks passed
@Robbepop Robbepop deleted the rf-simplify-error-handling branch November 2, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant