Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix miri reported UB in FuncRef and ExternRef conversions #1201

Merged
merged 6 commits into from
Sep 26, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Sep 26, 2024

Closes #1200.

This PR implements the solution brought forward in this comment:
#1200 (comment)

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.81%. Comparing base (c0f79e1) to head (576d843).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/src/externref.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1201      +/-   ##
==========================================
- Coverage   80.82%   80.81%   -0.01%     
==========================================
  Files         300      299       -1     
  Lines       24906    24902       -4     
==========================================
- Hits        20130    20125       -5     
- Misses       4776     4777       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop
Copy link
Member Author

Robbepop commented Sep 26, 2024

The Miri (spec) job unfortunately is failing but not because some tests were failing but because it ran out of time which is partially expected and sometimes happens. We need a better solution than a hard-time out in the future.

In conclusion: The miri CI jobs pass again, generally.

@Robbepop Robbepop merged commit b918b25 into main Sep 26, 2024
18 of 19 checks passed
@Robbepop Robbepop deleted the rf-fix-miri-errors branch September 26, 2024 16:47
Robbepop added a commit that referenced this pull request Sep 28, 2024
* add #[repr(C)] to Transposer as mandated by the Rust reference

* add getters for Transposer::{value,reftype}

* make the transmute explicit

* fix miri reported UB in reftype conversions

* remove reftype.rs utility

No longer needed.

* fix unrelated clippy warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate why CI miri jobs are failing recently
1 participant