Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve storeN instruction encoding with immediates #1194

Merged
merged 18 commits into from
Sep 25, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Sep 25, 2024

This improves encoding of Wasmi storeN instructions (store instructions that wrap before storing) that are using immediate values by wrapping the input value at translation time before actually using it which reduces the number of allocated function local constants substantially.

Affected instructions: i{32,64}_store{8,16,32}

@Robbepop Robbepop marked this pull request as ready for review September 25, 2024 12:27
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 99.50739% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.82%. Comparing base (903bb5c) to head (e24a947).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/src/engine/translator/utils.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
+ Coverage   80.79%   80.82%   +0.02%     
==========================================
  Files         300      300              
  Lines       24864    24907      +43     
==========================================
+ Hits        20089    20131      +42     
- Misses       4775     4776       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit d299f43 into main Sep 25, 2024
16 of 18 checks passed
@Robbepop Robbepop deleted the rf-improve-istore-wrap-encoding branch September 25, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant