iOS Support - via .dylib & Headless Runtime

[NathHorrigan]

Description

This PR makes some fairly simple changes to feature flags so that forks originally intended *-apple-darwin now work for both aarch64-apple-ios/x86_64-apple-ios.

Review

• Add a short description of the change to the CHANGELOG.md file

[syrusakbary]

Undelete this :)

[NathHorrigan]

Doing so causes this:

error[E0432]: unresolved import `super::super::engine::wasmer_compiler_t`
 --> lib/c-api/src/wasm_c_api/unstable/engine.rs:4:43
  |
4 | use super::super::engine::{wasm_config_t, wasmer_compiler_t, wasmer_engine_t};
  |                                           ^^^^^^^^^^^^^^^^^ no `wasmer_compiler_t` in `wasm_c_api::engine`

[NathHorrigan]

Which is used by this method:

pub extern "C" fn wasmer_is_compiler_available(compiler: wasmer_compiler_t) -> bool {
    match compiler {
        wasmer_compiler_t::CRANELIFT if cfg!(feature = "cranelift") => true,
        wasmer_compiler_t::LLVM if cfg!(feature = "llvm") => true,
        wasmer_compiler_t::SINGLEPASS if cfg!(feature = "singlepass") => true,
        _ => false,
    }
}

[Hywan]

Please, keep #[cfg(feature = "compiler")] here. But add:

use super::super::engine:{wasm_config_t, wasmer_engine_t};
#[cfg(feature = "compiler")]
use super::super::engine::wasmer_compiler_t;

in lib/c-api/src/wasm_c_api/unstable/engine.rs. It's a bug here.

Thank you very much!

[NathHorrigan]

I added those compiler conditions, I had to add some others to fix more build errors though?

[syrusakbary]

bors try

[bors]

try

Build failed:

• Test on linux-x64

[NathHorrigan]

bors try

Edit: Eh... nice try

[bors]

🔒 Permission denied

Existing reviewers: click here to make NathHorrigan a reviewer

[Hywan]

Thank you very much for your work! I believe we are on a good track. I hope my review provides relevant inputs :-).

[Hywan]

Please, keep #[cfg(feature = "compiler")] here. But add:

use super::super::engine:{wasm_config_t, wasmer_engine_t};
#[cfg(feature = "compiler")]
use super::super::engine::wasmer_compiler_t;

in lib/c-api/src/wasm_c_api/unstable/engine.rs. It's a bug here.

Thank you very much!

[NathHorrigan]

That should be ready for you now @syrusakbary !

[syrusakbary]

bors try

[NathHorrigan]

I also updated the Xcode build scripts so you shouldn't have any issues on your M1 machine :)

[syrusakbary]

bors try

[bors]

try

Already running a review

[syrusakbary]

bors try-

[syrusakbary]

bors try

[syrusakbary]

bors try-

[syrusakbary]

bors try

[syrusakbary]

Bors is weirdly failing:

{{:badmatch,   {:error, :merge_branch, 403,    "{\"message\":\"Resource not accessible by integration\",\"documentation_url\":\"https://docs.github.com/rest/reference/repos#merge-a-branch\"}",    "8D04:1534:5623A3:D8B0BD:611ED99C"}},  [    {BorsNG.GitHub, :merge_branch!, 2,     [file: 'lib/github/github.ex', line: 185]},    {BorsNG.Worker.Attemptor, :start_attempt, 2,     [file: 'lib/worker/attemptor.ex', line: 204]},    {BorsNG.Worker.Attemptor, :handle_cast, 2,     [file: 'lib/worker/attemptor.ex', line: 61]},    {:gen_server, :try_dispatch, 4,     [file: 'gen_server.erl', line: 695]},    {:gen_server, :handle_msg, 6,     [file: 'gen_server.erl', line: 771]},    {:proc_lib, :init_p_do_apply, 3,     [file: 'proc_lib.erl', line: 226]}  ]}
--

[NathHorrigan]

That's very strange, according to Google that is an error caused when the userr calling Bors doesn't have permission. Do you wanna try again?

[NathHorrigan]

@syrusakbary ^^

[syrusakbary]

bors try

[bors]

try

Already running a review

[syrusakbary]

bors try-

[syrusakbary]

bors try

[syrusakbary]

I think is because github actions file got changed. I'll close this PR and reopen as a new one from Wasmer (also I'll add you as contributor so you can directly push to the feature/ios-headless-support branch in this repo (without needing a fork)