Introduce a testing framework for Wasmer Pack #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
added
category: feature
Michael-F-Bryan
force-pushed
the
integration-test-framework
branch
from
ec7c9e1
to
583a6eb
Compare
|
⏱ Workflow Timer ⏱ Make sure you keep an eye on build times! One of this project's goals is to keep CI runs under 5 minutes so developers can maintain fast edit-compile-test cycles.
🤖 Beep. Boop. I'm a bot. If you find any issues, please report them to https://github.com/Michael-F-Bryan/workflow-timer. |
|
After talking with @dynamite-bud, we're thinking we might merge this PR as-is and follow up with PRs that implement JavaScript testing and refactor the workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a
wasmer-pack-testingcrate that people can use when writing integration tests for bindings generated bywasmer-pack. At the moment, support for Python is implemented, and we'll implement the JavaScript tests in a future PR.CC #87.
Context
At the moment, creating and running integration tests for Wasmer Pack is quite cumbersome because it relies on several external tools (
cargo wapm,yarn,python,pip, etc.).Wasmer Pack also has integration tests which run the real
wasmer/wasmer-packandwasmer/wabtpackages. This is great because we're testing real-world packages, but it's also unhelpful because those integration tests are testing real-world packages which don't necessarily include every little feature of WAI/Wasmer Pack that we'd like to test.Checklist