Add static build when tag "static_build" is used #40

yaslama · 2019-06-10T14:00:53Z

No description provided.

Hywan · 2019-06-11T06:47:25Z

Thanks for the proposal. I would suggest to find a way to avoid copying the bridge.go content as most as possible. I'm OK to support static builds though. Do you have a particular use case for that?

Hywan

Please, don't copy the content of bridge.go in another file.

yaslama · 2019-06-11T08:40:36Z

I'm OK to support static builds though. Do you have a particular use case for that?

In some case, it's a lot easier to copy a single executable to another place without having to install a bunch of dependencies which need to be installed in the same place as the builder (wasmer_link_static.go in this case) unless chrpath is used.

yaslama · 2019-06-11T08:41:32Z

Please, don't copy the content of bridge.go in another file.

No problem. I modified the PR.

yaslama · 2019-06-11T09:06:57Z

BTW, I tested the static compilation in linux only and the .a file needs imo to be replaced by a release binary from https://github.com/wasmerio/wasmer

Hywan · 2019-06-11T10:02:38Z

bors try

bors · 2019-06-11T10:06:02Z

try

Build succeeded

…rity

Hywan · 2019-06-24T09:29:14Z

Can you update the CircleCI configuration to test the static build please?

yaslama · 2019-07-02T07:12:17Z

Can you update the CircleCI configuration to test the static build please?

I modified the justfile to build and test using also the static library

yaslama · 2019-07-17T10:40:20Z

Hi @Hywan, what is missing from this PR in order to be merged?

Hywan · 2019-07-17T11:22:58Z

Yeah, after a quicklook, everything seems good! Thank you. I'll merge it as soon as possible (today or Friday).

Hywan · 2019-07-31T18:53:58Z

Sorry, I'm in holidays, will merge it in few days!

Hywan

Looks good to me, thank you very much! And sorry for the delay.

Hywan · 2019-08-14T12:57:01Z

bors r+

40: Add static build when tag "static_build" is used r=Hywan a=yaslama Co-authored-by: Yaacov Akiba Slama <[email protected]>

bors · 2019-08-14T13:00:26Z

Build failed

ci/circleci: build-and-test-macos

yaslama · 2019-08-14T13:48:14Z

Can you retry please?

Hywan · 2019-08-28T12:24:39Z

bors r+

40: Add static build when tag "static_build" is used r=Hywan a=yaslama Co-authored-by: Yaacov Akiba Slama <[email protected]>

bors · 2019-08-28T12:28:13Z

Build failed

ci/circleci: build-and-test-macos

Hywan · 2019-08-28T12:45:13Z

I think the static lib is different for macOS or some Linux distrib. I wonder whether it's good to embed it directly in the repository 🤔?

wasmer/wasmer_link_dynamic.go

wasmer/wasmer_link_static.go

AdamSLevy · 2020-02-17T21:24:54Z

I really like the approach that this PR is taking, and a similar approach could be used for conditional compilation of various backends and metering features.

…ist.

Hywan · 2020-05-12T14:19:23Z

bors try

bors · 2020-05-12T14:19:29Z

try

Merge conflict.

Hywan · 2020-05-12T14:19:58Z

Please can you fix the conflicts with master, so that we can run the tests.

FlorianFranzen · 2020-06-16T11:58:13Z

@yaslama: Are you still working on this? I would love to see this merged.

yaslama · 2020-06-21T19:32:20Z

@Hywan I fixed the conflicts with master.

The macos linker doesn't support the -l:<file> syntax, so the dynamic and static libraries cannot be in the same directory.

yaslama · 2020-06-29T09:49:41Z

@Hywan Do you think that this PR can be merged soon?

FlorianFranzen · 2020-08-04T09:29:58Z

@Hywan It has been another month with no movement. Could we please get this merged?

Hywan · 2020-08-17T11:40:13Z

bors try

Hywan · 2020-08-17T11:40:54Z

@FlorianFranzen The entire team was extremely busy for a giant set of improvements for Wasmer. Hence my silence on those projects. Now I'm back on tracks. Give me time please.

Hywan · 2020-08-17T11:43:09Z

I don't think the provided .a static lib in this PR is compatible between macOS and Linux. We should find a way to differentiate them. What do you think @yaslama?

bors · 2020-08-17T11:49:52Z

try

Build succeeded:

yaslama · 2020-08-17T13:05:55Z

I don't think the provided .a static lib in this PR is compatible between macOS and Linux. We should find a way to differentiate them. What do you think @yaslama?

We can put the static libraries in a folder per arch. But on second thought, it's perhaps better to let the user build herself the static libraries. What do you think?

FlorianFranzen · 2020-08-17T13:44:32Z

@Hywan Of course, thank you for taking another look.

My main concern would be that it is easy to use with the default go tool chain. I am not sure how far that is possible if you are required to compile wasmer from source. But I am not really a go expert...

FlorianFranzen · 2021-01-11T11:02:44Z

@Hywan I know you have been working hard on the v1.0.0 release, but has there been any update on static builds?

Hywan · 2021-02-16T14:48:51Z

Closing in favor of #190 and #193. With those PR, it's now possible to build your own custom libs (dylib or static lib) and link against wasmer-go. See https://github.com/wasmerio/wasmer-go#supported-platforms, then unfold the What to do if your platform is missing? Section.

FlorianFranzen · 2021-03-05T16:30:42Z

@Hywan Most go programs are statically linked i.e. do not depend on shared libraries. go-wasmer breaks with this and I am not sure why. To ship any go binary that uses go-wasmer, I have to fish libwasmer.so out of my go module path after building.

Would it really be to much to ask to use a static build libwasmer instead of the shared one. As far as I can tell you would only need to change the crate type from cdylib to staticlib.

Hywan self-assigned this Jun 11, 2019

Hywan added 🎉 enhancement New feature or request 📦 component-runtime About the Wasm runtime labels Jun 11, 2019

Hywan suggested changes Jun 11, 2019

View reviewed changes

Add static build when tag "static_build" is used

c66da3c

yaslama force-pushed the static_build branch from 4286d6a to c66da3c Compare June 11, 2019 08:31

yaslama changed the title ~~Add static build when tag "static" is used~~ Add static build when tag "static_build" is used Jun 11, 2019

bors bot added a commit that referenced this pull request Jun 11, 2019

Try #40:

ac240aa

Use explicitly the static library because the shared library has prio…

3afabc6

…rity

Add support for testing build with static library

1289499

yaslama added 3 commits July 4, 2019 09:35

Merge branch 'master' into static_build

a33f4d7

Merge branch 'master' into static_build

32ee329

Update Wasmer static library to 0.5.5

eb5b2ec

Hywan approved these changes Aug 14, 2019

View reviewed changes

bors bot added a commit that referenced this pull request Aug 14, 2019

Merge #40

64d0276

40: Add static build when tag "static_build" is used r=Hywan a=yaslama Co-authored-by: Yaacov Akiba Slama <[email protected]>

Fix bash variable check

14c49b0

bors bot added a commit that referenced this pull request Aug 28, 2019

Merge #40

906cae4

40: Add static build when tag "static_build" is used r=Hywan a=yaslama Co-authored-by: Yaacov Akiba Slama <[email protected]>

AdamSLevy reviewed Feb 17, 2020

View reviewed changes

wasmer/wasmer_link_dynamic.go Show resolved Hide resolved

AdamSLevy reviewed Feb 17, 2020

View reviewed changes

wasmer/wasmer_link_static.go Show resolved Hide resolved

Don't link with librt on macos because it's not needed and doesn't ex…

2aa55a5

…ist.

Merge branch 'master' into static_build

748bb43

Move static libraries to a separate subdirectory

b2a8220

The macos linker doesn't support the -l:<file> syntax, so the dynamic and static libraries cannot be in the same directory.

bors bot added a commit that referenced this pull request Aug 17, 2020

Try #40:

3b909d5

Hywan closed this Feb 16, 2021

Add static build when tag "static_build" is used #40

Add static build when tag "static_build" is used #40

Conversation

yaslama commented Jun 10, 2019

Hywan commented Jun 11, 2019

Hywan left a comment

Choose a reason for hiding this comment

yaslama commented Jun 11, 2019 • edited Loading

yaslama commented Jun 11, 2019 • edited Loading

yaslama commented Jun 11, 2019

Hywan commented Jun 11, 2019

bors bot commented Jun 11, 2019

try

Build succeeded

Hywan commented Jun 24, 2019

yaslama commented Jul 2, 2019

yaslama commented Jul 17, 2019

Hywan commented Jul 17, 2019

Hywan commented Jul 31, 2019

Hywan left a comment

Choose a reason for hiding this comment

Hywan commented Aug 14, 2019

bors bot commented Aug 14, 2019

Build failed

yaslama commented Aug 14, 2019

Hywan commented Aug 28, 2019

bors bot commented Aug 28, 2019

Build failed

Hywan commented Aug 28, 2019

AdamSLevy commented Feb 17, 2020

Hywan commented May 12, 2020

bors bot commented May 12, 2020

try

Hywan commented May 12, 2020

FlorianFranzen commented Jun 16, 2020

yaslama commented Jun 21, 2020

yaslama commented Jun 29, 2020

FlorianFranzen commented Aug 4, 2020

Hywan commented Aug 17, 2020

Hywan commented Aug 17, 2020

Hywan commented Aug 17, 2020

bors bot commented Aug 17, 2020

try

yaslama commented Aug 17, 2020 • edited Loading

FlorianFranzen commented Aug 17, 2020 • edited Loading

FlorianFranzen commented Jan 11, 2021

Hywan commented Feb 16, 2021

FlorianFranzen commented Mar 5, 2021

yaslama commented Jun 11, 2019 •

edited

Loading

yaslama commented Jun 11, 2019 •

edited

Loading

yaslama commented Aug 17, 2020 •

edited

Loading

FlorianFranzen commented Aug 17, 2020 •

edited

Loading