Add an E2E build & test, check linked dylibs of the executable #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2021
hanabi1224
force-pushed
the
e2e-check-dylib
branch
from
470f5ef
to
19f579e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Echo #232, current dynamically linked libwasmer makes it hard to copy go executables around. This PR adds and E2E test that builds a sample program with local wasmer-go and then check whether libwasmer is statically linked.
There'll be some other PRs to make the actual linking changes, which can be verified by this one.
P.S. I run CI job in my fork with all three changes and get result here. E2E test result shows libwasmer are statically linked successfully on both targets.
I don't have test envs to verify linux-aarch64 and darwin-aarch64 so I didn't not send PR for them, but I guess the same change should be sufficient.