Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State lookups use a ton of bandwidth #203

Closed
thomastaylor312 opened this issue Oct 26, 2023 · 0 comments · Fixed by #211
Closed

State lookups use a ton of bandwidth #203

thomastaylor312 opened this issue Oct 26, 2023 · 0 comments · Fixed by #211
Assignees
@thomastaylor312
Labels
bug Something isn't working

Comments

@thomastaylor312
Copy link
Contributor

thomastaylor312 commented Oct 26, 2023 •
edited
Loading

When running wadm in production at cosmonic, we discovered that wadm uses a ton of bandwidth querying data from the store. Back of napkin math put us around 500GB/month just for querying linkdefs and wadm state data. I will document a more elegant solution in another issue, but we should probably just do a single "snapshot" lookup of state (wadm_state + linkdefs + claims) that is then used by all scalers handling a given event. This means that rather than each scaler querying individually, it will just be queried once.
@thomastaylor312 thomastaylor312 added the bug Something isn't working label Oct 26, 2023
@thomastaylor312 thomastaylor312 self-assigned this Oct 26, 2023
This was referenced Oct 26, 2023
Open
Open
thomastaylor312 added a commit to thomastaylor312/wadm that referenced this issue Nov 2, 2023
@thomastaylor312
fix(storage): Updates scalers to do a single data lookup per event
bb9456d 
This works by looking up all the data once per event (whenever scalers
are called). This reduces lookups of links by at least 40% and should
reduce data usage as well (though not as much as doing some sort of
caching would)

Fixes wasmCloud#203

Signed-off-by: Taylor Thomas <[email protected]>
@thomastaylor312 thomastaylor312 mentioned this issue Nov 2, 2023
Merged
thomastaylor312 added a commit that referenced this issue Nov 2, 2023
@thomastaylor312
fix(storage): Updates scalers to do a single data lookup per event (#211
54ee1a4 
)

This works by looking up all the data once per event (whenever scalers
are called). This reduces lookups of links by at least 40% and should
reduce data usage as well (though not as much as doing some sort of
caching would)

Fixes #203

Signed-off-by: Taylor Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomastaylor312 thomastaylor312

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(storage): Updates scalers to do a single data lookup per event thomastaylor312/wadm
1 participant
@thomastaylor312