Input search fixes #677

wp-aberg · 2024-12-10T18:36:06Z

What I did

This PR consolidates several fixes to InputSearch that have been reported over the past few weeks

CFE-296 To sanitize input and prevent a regular expression error
Enter ( in the input and not get JS errors
CFE-344 Externally clearing when the input is controlled
clear input text in controlled example with external button
CFE-345 To honor the disabled prop in list items
new disabled story
CFE-346 To honor the css prop in list items
Style list items in playroom
CFE-347 To have an example in the documentation using the onSelect callback
see new Selected example

…tyling

…example

vercel · 2024-12-10T18:36:11Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
wpds-ui-kit	✅ Ready (Inspect)	Visit Preview	Dec 10, 2024 6:36pm
wpds-ui-kit-storybook	✅ Ready (Inspect)	Visit Preview	Dec 10, 2024 6:36pm

wp-aberg added 7 commits December 6, 2024 14:31

fix: safely escape strings passed to RegExp in InputSearch

fc6538c

fix: allow props on InputSearch ListItem to pass through for custom s…

1d04506

…tyling

chore: add lint ignore

f24a7b2

fix: allow controlled InputSearch to be cleared by passing empty string

56e6c77

fix: include onSelect callback in InputSelect selected documentation …

8aed5b1

…example

fix: honor disabled prop in InputSearch list item

a4f1a35

chore: formatting

db888d3

wp-aberg requested a review from a team as a code owner December 10, 2024 18:36

artmsilva approved these changes Dec 10, 2024

View reviewed changes

atomictangerine approved these changes Dec 10, 2024

View reviewed changes

wp-aberg merged commit 62f88ec into main Dec 11, 2024
10 of 11 checks passed

wp-aberg deleted the input-search-fixes branch December 11, 2024 15:27