Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed onSurface to have the correct camel casing #571

Merged
merged 18 commits into from
Feb 20, 2024
Merged

Conversation

BrianAA
Copy link
Contributor

@BrianAA BrianAA commented Feb 13, 2024

What I did

  • Updated our color foundation doc
  • Fixed onSurface to have the correct camel casing.
  • Cleaned up some linting errors because they annoyed me.

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wpds-ui-kit ✅ Ready (Inspect) Visit Preview Feb 16, 2024 2:05am
wpds-ui-kit-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 2:05am

Lint calls out that I need to pass unnecessary dependencies to the useeffect breaking the input search from working. So removing them again.
Had a mispelling on the surface-highest
Spacing adjustment
width: "100%",
height: "100%",
borderRadius: "4px",
borderColor: "#e1e1e1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit pick could we use a color token if possible

flexDirection: "column",
alignItems: "center",
justifyContent: "center",
color: "black", // Default text color
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit pick could we use a color token if possible

import { styled, theme, Box } from "@washingtonpost/wpds-ui-kit";

export default function ThemeAndSemantic() {
const Layout = styled("div", {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move styled function definitions outside of the ThemeAndSemantic function scope? This will help improve rendering performance https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-unstable-nested-components.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing!

@artmsilva
Copy link
Contributor

Nit on the PR title. I suggest "fix: Fixed onSurface to have the correct camel casing" since we want to make sure our npm packages are versioned since there is a tokens.ts change.

Shame on Brian for not using a token for the border color lol
@BrianAA BrianAA changed the title doc: New color foundation documentation fix: Fixed onSurface to have the correct camel casing Feb 14, 2024
Copy link
Contributor

@artmsilva artmsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artmsilva artmsilva merged commit 9daca60 into main Feb 20, 2024
11 of 12 checks passed
@artmsilva artmsilva deleted the doc-color-update branch February 20, 2024 16:13
ebgranger added a commit that referenced this pull request Mar 18, 2024
* feat: bump wam to 1.24.0 (#546)

* fix: our lockfile area for build dot site was borked (#547)

* feat: add Dialog component

* chore(release): publish

* Apply automatic changes

* chore: add jason

* chore: add julie and erik

* feat: add snowfall to website for fun (#550)

* feat: turn snow on

* fix: remove snow

* fix: remove snow

* fix: remove tokens stylesheet

* feat: responsive screen size hook and css var (#548)

* chore(release): publish

* Apply automatic changes

* feat: add site footer back (#558)

* fix: fixes a scrollbar issue with select and our header component (#563)

* chore(release): publish

* Apply automatic changes

* feat: new dark mode colors and tokens (#554)

* chore(release): publish

* Apply automatic changes

* fix: reverted subtle and faint tokens (#566)

Reverted subtle and faint tokens to their original values. Added a description to flag them as legacy and subject to depreciated

* feat: remove search feature from docs site (#569)

* chore(release): publish

* fix: Fixed onSurface to have the correct camel casing (#571)

* WIP

* new color doc, fixed onSurface token to camel case

* fix linting errors

* revert concurrency for dev command

* Fixed search input

Lint calls out that I need to pass unnecessary dependencies to the useeffect breaking the input search from working. So removing them again.

* fix title and reorganize

* Fix to Update ThemeTokens.jsx

Had a mispelling on the surface-highest

* Update color.mdx

Spacing adjustment

* Fixed border token

Shame on Brian for not using a token for the border color lol

* Update ColorSamples.jsx to use tokens and theme

* Update ThemeTokens.jsx

* Improving Rendering performance per Art recs.

* Update ColorSamples.jsx

* Resolve conflicting Theme

* Update color.mdx

* Update color.mdx - adjusted spacing

* format and update from main

* fix: Change forCards modifier to forSurfaces (#576)

* fix: Change forCards modifier to forSurfaces

After much reflection and thought about the modifier forCards. I wanted to align more clearly to the tokens surface. To make it as clear as possible that its intention is to be used with surfaces

* Update ThemeTokens.jsx

Replace forCards to be forSurfaces in the theme example

* Update wpds.tokens.json

* Update wpds.tokens.json

* fix: first pass [STRY-70]

* Revert "fix: first pass [STRY-70]"

This reverts commit 47a5214.

* fix: only add needed files [STRY-70]

* fix: cleaned up [STRY-70]

* fix: cleaned up again [STRY-70]

* chore: add CSS ADR (#551)

* fix: linting [STRY-70]

* fix: ignoring .idea files [STRY-70]

* chore: updating for exp package

* wip

* chore(release): publish

* fix: update readme (#587)

* chore(release): publish

* chore(release): publish

* fix: formatting (#588)

* chore(release): publish

* fix: fixing formatting (#589)

* chore(release): publish

* Fixing formatting (#590)

* fix: fixing formatting

* fix: ignore tokens in linter

* chore(release): publish

* chore: commit wip (#591)

* fix: readme changes

* chore(release): publish

* Apply automatic changes

* wip

* wip

* chore(release): publish

* wip

* wip

* wip

* wip

* chore(release): publish

* wip

* chore(release): publish

* chore(release): publish

* wip

* wip

* formatting

---------

Co-authored-by: Arturo Silva <[email protected]>
Co-authored-by: wp-aberg <[email protected]>
Co-authored-by: site-eng-github-actions <[email protected]>
Co-authored-by: wp-aberg <[email protected]>
Co-authored-by: Arturo Silva <[email protected]>
Co-authored-by: artmsilva <[email protected]>
Co-authored-by: Brian Alfaro <[email protected]>
Co-authored-by: Valerie Hosler <[email protected]>
Co-authored-by: Valerie Massimi (Hosler) <[email protected]>
ebgranger added a commit that referenced this pull request Mar 21, 2024
* feat: bump wam to 1.24.0 (#546)

* fix: our lockfile area for build dot site was borked (#547)

* feat: add Dialog component

* chore(release): publish

* Apply automatic changes

* chore: add jason

* chore: add julie and erik

* feat: add snowfall to website for fun (#550)

* feat: turn snow on

* fix: remove snow

* fix: remove snow

* fix: remove tokens stylesheet

* feat: responsive screen size hook and css var (#548)

* chore(release): publish

* Apply automatic changes

* feat: add site footer back (#558)

* fix: fixes a scrollbar issue with select and our header component (#563)

* chore(release): publish

* Apply automatic changes

* feat: new dark mode colors and tokens (#554)

* chore(release): publish

* Apply automatic changes

* fix: reverted subtle and faint tokens (#566)

Reverted subtle and faint tokens to their original values. Added a description to flag them as legacy and subject to depreciated

* feat: remove search feature from docs site (#569)

* chore(release): publish

* fix: Fixed onSurface to have the correct camel casing (#571)

* WIP

* new color doc, fixed onSurface token to camel case

* fix linting errors

* revert concurrency for dev command

* Fixed search input

Lint calls out that I need to pass unnecessary dependencies to the useeffect breaking the input search from working. So removing them again.

* fix title and reorganize

* Fix to Update ThemeTokens.jsx

Had a mispelling on the surface-highest

* Update color.mdx

Spacing adjustment

* Fixed border token

Shame on Brian for not using a token for the border color lol

* Update ColorSamples.jsx to use tokens and theme

* Update ThemeTokens.jsx

* Improving Rendering performance per Art recs.

* Update ColorSamples.jsx

* Resolve conflicting Theme

* Update color.mdx

* Update color.mdx - adjusted spacing

* format and update from main

* fix: Change forCards modifier to forSurfaces (#576)

* fix: Change forCards modifier to forSurfaces

After much reflection and thought about the modifier forCards. I wanted to align more clearly to the tokens surface. To make it as clear as possible that its intention is to be used with surfaces

* Update ThemeTokens.jsx

Replace forCards to be forSurfaces in the theme example

* Update wpds.tokens.json

* Update wpds.tokens.json

* fix: first pass [STRY-70]

* Revert "fix: first pass [STRY-70]"

This reverts commit 47a5214.

* fix: only add needed files [STRY-70]

* fix: cleaned up [STRY-70]

* fix: cleaned up again [STRY-70]

* chore: add CSS ADR (#551)

* fix: linting [STRY-70]

* fix: ignoring .idea files [STRY-70]

* chore: updating for exp package

* wip

* chore(release): publish

* fix: update readme (#587)

* chore(release): publish

* chore(release): publish

* fix: formatting (#588)

* chore(release): publish

* fix: fixing formatting (#589)

* chore(release): publish

* Fixing formatting (#590)

* fix: fixing formatting

* fix: ignore tokens in linter

* chore(release): publish

* chore: commit wip (#591)

* fix: readme changes

* chore(release): publish

* Apply automatic changes

* wip

* wip

* chore(release): publish

* wip

* wip

* wip

* wip

* chore(release): publish

* wip

* chore(release): publish

* chore(release): publish

* wip

* wip

* formatting

* fix: transform select icon on open (#596)

* update from alpha.5

---------

Co-authored-by: Arturo Silva <[email protected]>
Co-authored-by: wp-aberg <[email protected]>
Co-authored-by: site-eng-github-actions <[email protected]>
Co-authored-by: wp-aberg <[email protected]>
Co-authored-by: Arturo Silva <[email protected]>
Co-authored-by: artmsilva <[email protected]>
Co-authored-by: Brian Alfaro <[email protected]>
Co-authored-by: Valerie Hosler <[email protected]>
Co-authored-by: Valerie Massimi (Hosler) <[email protected]>
ebgranger added a commit that referenced this pull request Apr 24, 2024
* chore: stub out dir

* chore: stub out dir

* chore: test nextjs 13 and 14 apps (page and app router) (#544)

* fix: remove defaultOpen from kitchen sink Tooltip example to prevent client server mismatch

* feat: updated InputLabel with latest Radix label component (#552)

* fix: take latest minor of Radix accordion

* feat: remove nanoid dependency (#555)

* fix: remove border for clear button on input search (#560)

* feat: move Button, Icon, theme, and VisuallyHidden to v2 package  (#562)

* feat: card (#564)

* feat: update Accordion to React 18 (#565)

* feat: fresh install with updated node/npm (#574)

* V2 switch (#570)

* wip

* wip

* wip

* wip

* wip

* feat: fix React issue in story

* feat: merge and install

* fix: fixing formatting

* fix: reset apps dir

* fix: trying to reset the apps dir

* fix: i don't know how dialog went mising (#579)

* feat: v2 mass components upgrade/migration (#578)

* wip

* wip

* wip

* wip

* wip

* wip

* chore: commit wip

* lol idk if this is wise

* lol idk if this is wise

* chore: commit wip

* chore: commit wip

* chore: commit wip

* chore: commit wip

* chore: commit wip

* chore: commit wip

* chore: commit wip

* chore: commit wip

* chore: commit wip

* chore: commit wip

* chore: commit wip

* chore: commit wip

* chore: commit wip

* chore: commit wip

* chore: commit wip

* chore: commit wip

* Upgrade mass boop with v2 (#580)

* fix: i don't know how dialog went mising (#579)

* chore: commit wip

* chore: commit wip

---------

Co-authored-by: Edward Granger <[email protected]>

* chore: commit wip

* fix: correcting merge issue

* fix: remove ui from jest tests

* fix: experiment if pointerevents check will fix close button error in Safari

* fix: prettify dialog test

* fix: prettify dialog test

* fix: tweaking dialog to hopefully pass storybook check in safari

* fix: allow unused react in linter since nextjs wants to play by diff rules lol

* fix: run next link upgrade codemod

* fix: format

---------

Co-authored-by: Edward Granger <[email protected]>
Co-authored-by: Andrew Berg <[email protected]>

* fix: Playroom fix (#583)

* fix: merging main and resolving conflicts (#585)

* fix: merging main and resolving conflicts

* wip

* wip

* wip

* more changes to get docs site working

* syntax error

* running prettier

* feat: update package-lock

* chore(release): publish

* chore: commit wip

* chore: commit wip

* chore: commit wip

* chore(release): publish

* chore(release): publish

* chore(release): publish

* V2 package lock upgraded (#593)

* feat: bump wam to 1.24.0 (#546)

* fix: our lockfile area for build dot site was borked (#547)

* feat: add Dialog component

* chore(release): publish

* Apply automatic changes

* chore: add jason

* chore: add julie and erik

* feat: add snowfall to website for fun (#550)

* feat: turn snow on

* fix: remove snow

* fix: remove snow

* fix: remove tokens stylesheet

* feat: responsive screen size hook and css var (#548)

* chore(release): publish

* Apply automatic changes

* feat: add site footer back (#558)

* fix: fixes a scrollbar issue with select and our header component (#563)

* chore(release): publish

* Apply automatic changes

* feat: new dark mode colors and tokens (#554)

* chore(release): publish

* Apply automatic changes

* fix: reverted subtle and faint tokens (#566)

Reverted subtle and faint tokens to their original values. Added a description to flag them as legacy and subject to depreciated

* feat: remove search feature from docs site (#569)

* chore(release): publish

* fix: Fixed onSurface to have the correct camel casing (#571)

* WIP

* new color doc, fixed onSurface token to camel case

* fix linting errors

* revert concurrency for dev command

* Fixed search input

Lint calls out that I need to pass unnecessary dependencies to the useeffect breaking the input search from working. So removing them again.

* fix title and reorganize

* Fix to Update ThemeTokens.jsx

Had a mispelling on the surface-highest

* Update color.mdx

Spacing adjustment

* Fixed border token

Shame on Brian for not using a token for the border color lol

* Update ColorSamples.jsx to use tokens and theme

* Update ThemeTokens.jsx

* Improving Rendering performance per Art recs.

* Update ColorSamples.jsx

* Resolve conflicting Theme

* Update color.mdx

* Update color.mdx - adjusted spacing

* format and update from main

* fix: Change forCards modifier to forSurfaces (#576)

* fix: Change forCards modifier to forSurfaces

After much reflection and thought about the modifier forCards. I wanted to align more clearly to the tokens surface. To make it as clear as possible that its intention is to be used with surfaces

* Update ThemeTokens.jsx

Replace forCards to be forSurfaces in the theme example

* Update wpds.tokens.json

* Update wpds.tokens.json

* fix: first pass [STRY-70]

* Revert "fix: first pass [STRY-70]"

This reverts commit 47a5214.

* fix: only add needed files [STRY-70]

* fix: cleaned up [STRY-70]

* fix: cleaned up again [STRY-70]

* chore: add CSS ADR (#551)

* fix: linting [STRY-70]

* fix: ignoring .idea files [STRY-70]

* chore: updating for exp package

* wip

* chore(release): publish

* fix: update readme (#587)

* chore(release): publish

* chore(release): publish

* fix: formatting (#588)

* chore(release): publish

* fix: fixing formatting (#589)

* chore(release): publish

* Fixing formatting (#590)

* fix: fixing formatting

* fix: ignore tokens in linter

* chore(release): publish

* chore: commit wip (#591)

* fix: readme changes

* chore(release): publish

* Apply automatic changes

* wip

* wip

* chore(release): publish

* wip

* wip

* wip

* wip

* chore(release): publish

* wip

* chore(release): publish

* chore(release): publish

* wip

* wip

* formatting

---------

Co-authored-by: Arturo Silva <[email protected]>
Co-authored-by: wp-aberg <[email protected]>
Co-authored-by: site-eng-github-actions <[email protected]>
Co-authored-by: wp-aberg <[email protected]>
Co-authored-by: Arturo Silva <[email protected]>
Co-authored-by: artmsilva <[email protected]>
Co-authored-by: Brian Alfaro <[email protected]>
Co-authored-by: Valerie Hosler <[email protected]>
Co-authored-by: Valerie Massimi (Hosler) <[email protected]>

* fix: transform Select arrow on open (#597)

* V2 package lock upgraded (#602)

* feat: bump wam to 1.24.0 (#546)

* fix: our lockfile area for build dot site was borked (#547)

* feat: add Dialog component

* chore(release): publish

* Apply automatic changes

* chore: add jason

* chore: add julie and erik

* feat: add snowfall to website for fun (#550)

* feat: turn snow on

* fix: remove snow

* fix: remove snow

* fix: remove tokens stylesheet

* feat: responsive screen size hook and css var (#548)

* chore(release): publish

* Apply automatic changes

* feat: add site footer back (#558)

* fix: fixes a scrollbar issue with select and our header component (#563)

* chore(release): publish

* Apply automatic changes

* feat: new dark mode colors and tokens (#554)

* chore(release): publish

* Apply automatic changes

* fix: reverted subtle and faint tokens (#566)

Reverted subtle and faint tokens to their original values. Added a description to flag them as legacy and subject to depreciated

* feat: remove search feature from docs site (#569)

* chore(release): publish

* fix: Fixed onSurface to have the correct camel casing (#571)

* WIP

* new color doc, fixed onSurface token to camel case

* fix linting errors

* revert concurrency for dev command

* Fixed search input

Lint calls out that I need to pass unnecessary dependencies to the useeffect breaking the input search from working. So removing them again.

* fix title and reorganize

* Fix to Update ThemeTokens.jsx

Had a mispelling on the surface-highest

* Update color.mdx

Spacing adjustment

* Fixed border token

Shame on Brian for not using a token for the border color lol

* Update ColorSamples.jsx to use tokens and theme

* Update ThemeTokens.jsx

* Improving Rendering performance per Art recs.

* Update ColorSamples.jsx

* Resolve conflicting Theme

* Update color.mdx

* Update color.mdx - adjusted spacing

* format and update from main

* fix: Change forCards modifier to forSurfaces (#576)

* fix: Change forCards modifier to forSurfaces

After much reflection and thought about the modifier forCards. I wanted to align more clearly to the tokens surface. To make it as clear as possible that its intention is to be used with surfaces

* Update ThemeTokens.jsx

Replace forCards to be forSurfaces in the theme example

* Update wpds.tokens.json

* Update wpds.tokens.json

* fix: first pass [STRY-70]

* Revert "fix: first pass [STRY-70]"

This reverts commit 47a5214.

* fix: only add needed files [STRY-70]

* fix: cleaned up [STRY-70]

* fix: cleaned up again [STRY-70]

* chore: add CSS ADR (#551)

* fix: linting [STRY-70]

* fix: ignoring .idea files [STRY-70]

* chore: updating for exp package

* wip

* chore(release): publish

* fix: update readme (#587)

* chore(release): publish

* chore(release): publish

* fix: formatting (#588)

* chore(release): publish

* fix: fixing formatting (#589)

* chore(release): publish

* Fixing formatting (#590)

* fix: fixing formatting

* fix: ignore tokens in linter

* chore(release): publish

* chore: commit wip (#591)

* fix: readme changes

* chore(release): publish

* Apply automatic changes

* wip

* wip

* chore(release): publish

* wip

* wip

* wip

* wip

* chore(release): publish

* wip

* chore(release): publish

* chore(release): publish

* wip

* wip

* formatting

* fix: transform select icon on open (#596)

* update from alpha.5

---------

Co-authored-by: Arturo Silva <[email protected]>
Co-authored-by: wp-aberg <[email protected]>
Co-authored-by: site-eng-github-actions <[email protected]>
Co-authored-by: wp-aberg <[email protected]>
Co-authored-by: Arturo Silva <[email protected]>
Co-authored-by: artmsilva <[email protected]>
Co-authored-by: Brian Alfaro <[email protected]>
Co-authored-by: Valerie Hosler <[email protected]>
Co-authored-by: Valerie Massimi (Hosler) <[email protected]>

* update lock file again

* fix: make input helper and error block level elements to preserve formatting

* wip

* fix: add nanoid back (#607)

* chore(release): publish

* feat: add v2 docs switcher (#608)

* V2 updating deps (#612)

* wip

* wip

* wip

* fix: new colors are not showing up (#614)

* fix: new colors are not showing up

* chore: commit wip

* chore(release): publish

* wip

* fix: add tokens specifier to exports (#616)

* chore: commit changes from build

* wip

* chore: remove exports

* chore(release): publish

* V2 migrate theme (#619)

* wip

* wip

* wi

* wip

* wip

* wip

* wip

* wip

* chore(release): publish

* V2 resolving conflicts (#620)

* wip

* wip

* wip

* wip (#621)

* wip

* chore(release): publish

* wip

* wip

* feat: final update for v2 branch

---------

Co-authored-by: Andrew Berg <[email protected]>
Co-authored-by: wp-aberg <[email protected]>
Co-authored-by: Edward Granger <[email protected]>
Co-authored-by: site-eng-github-actions <[email protected]>
Co-authored-by: wp-aberg <[email protected]>
Co-authored-by: artmsilva <[email protected]>
Co-authored-by: Brian Alfaro <[email protected]>
Co-authored-by: Valerie Hosler <[email protected]>
Co-authored-by: Valerie Massimi (Hosler) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants