fix: changed import style to fix missing api table #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wp-aberg
requested review from
artmsilva,
atomictangerine and
clairehhelms
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wp-aberg
commented
Dec 22, 2022
| @@ -163,6 +162,7 @@ export const InputText = React.forwardRef<HTMLInputElement, InputTextProps>( | |||
| }, [ref, internalRef]); | |||
|
|
|||
| useEffect(() => { | |||
| globalInputAutoFillTriggerAnimations(); | |||
There was a problem hiding this comment.
Not related to the API table, but this code was being called every render. Just once in the use effect is all that's strictly necessary.
wp-aberg
commented
Dec 22, 2022
| @@ -179,7 +179,7 @@ export const InputText = React.forwardRef<HTMLInputElement, InputTextProps>( | |||
| return () => { | |||
| element?.removeEventListener("animationstart", onAnimationStart, false); | |||
| }; | |||
| }); | |||
| }, []); | |||
There was a problem hiding this comment.
Adding the empty array ensures that this only gets called once on the initial render.
artmsilva
approved these changes
Jan 3, 2023
atomictangerine
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR changes the import of React to make API tables work. This is a known issue in
react-typescript-docgenstyleguidist/react-docgen-typescript#323WPDS-1293