-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #380
Merged
Merged
Develop #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Renovate Bot <[email protected]>
* Theme provider to Syllabus & context to containers * Add context on components in Syllabus which may require fix for dark mode * feat: replace @reach/router to react-router v6 * feat: update header for all apps * fix: reinstall react-router-dom v6 and history after rebase * feat: add new themes * fix: lock files * feat: install TailwindCSS on Campus * feat: install TailwindCSS on Syllabus * feat: change theme-toggle color according to current theme * fix: change locations of tailwind import; remove unused log * feat: dark theme on Timetable * Feat: Added new sidebar icons from material ui icons * Feat: Separated icons into different component * fix: added package json and pnpm lock updates * feat: pass isDark property to styled components * feat: dark theme on Syllabus (CourseItem not yet) * fix: wrap ThemeProvider on Nav; use new theme colors * fix: use className instead of passing theme as props * feat: dark theme on CourseInfo (not completed) * fix: Made theme types exportable * fix: created sidebar wrapper locally instead of bit * fix: Fixed styling of icon group button * feat: added user profile icon * feat: Added dark mode styling to other links * fix: moved browser router wrapper outside to fix navigation * fix: used const instead of let for navigation hook * fix: fixed import order * feat: CourseInfo dark mode * feat: Made title logo svg into a component * fix: made title logo text colour change when theme toggle * fix: fixed extra stylings when dark mode * fix: updated package versions and pnpm lock file * feat: update loading-spinner & solve background color flicker while loading page in dark mode * feat: added dark mode styling to about us pages * feat: added dark mode styling to extra pages * feat: dark theme to mobile bottom nav * feat: update header & loading-spinner & body tag background color * feat: added dark mode background * fix: fixed title logo on sidebar not changing colours when switching modes * fix: added tab colours when dark mode * fix: added dark mode colours to partner page text * feat: dark mode for Labs * fix: related courses width * feat: update spinner in Syllabus; dark mode for Campus * fix: timetable course item scrollable space height * feat: make timetable course item darker in dark mode * feat: install tailwind in feeds (not used yet) * feat: redirecting page styling * feat: update sign in modal * feat: updated header component and pnpm lock file accordingly * fix: updated colors and header dependencies * fix: eslint fixes for campus folder * feat: added dark mode styling to campus folder * fix: eslint fixes in syllabus folder * fix: updated dark mode styling * fix: updated dark mode syllabus * fix: updated dark mode styling root folder * fix: syllabus border & step arrow color * fix: fixed styling for social media icons in partners * fix: removed unused imports * fix: Or-button dark mode color * fix: remove FilterWarningsPlugin * fix: update lock files * fix: remove -y option * fix: update lock files * fix: update @aws-amplify/auth in syllabus * fix: update loading spinner in Feeds * fix: add theme prop to LoadingSpinner in Feeds Co-authored-by: YHhaoareyou <[email protected]>
* feat: dark mode & new messages on welcome modal * fix: dark mode on sign in modal & user login icon
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
* feat: added quarterColors for both light and dark mode * feat: Added google analytics to theme changes * fix: fixed user profile icon to make it consistent * fix: code refactoring * fix: code refactoring in syllabus * feat: added dark semantic colors * fix: added colors based on numbers too * fix: added a todo comment * fix: fix semantic text colors dark mode * feat: update quarter switch colors & icons * feat: update timetable course items and color selector with new theme colors Co-authored-by: Nicholas Narmada <[email protected]>
* feat: Dark mode for pro tips and colors selector popup in Timetable * feat: update theme colors dependency for all apps
nichnarmada
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: