Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How did this even happen... + more tests #256

Merged
merged 6 commits into from
Dec 30, 2020
Merged

How did this even happen... + more tests #256

merged 6 commits into from
Dec 30, 2020

Conversation

krzys-h
Copy link
Member

@krzys-h krzys-h commented Dec 28, 2020

Too much rebasing, probably
image


This change is Reviewable

@krzys-h krzys-h changed the title How did this even happen... How did this even happen... + more tests Dec 29, 2020
@codecov-io
Copy link

codecov-io commented Dec 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@ead7288). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #256   +/-   ##
=========================================
  Coverage          ?   89.75%           
=========================================
  Files             ?       16           
  Lines             ?     2607           
  Branches          ?        0           
=========================================
  Hits              ?     2340           
  Misses            ?      267           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead7288...5e98d5c. Read the comment docs.

@krzys-h krzys-h mentioned this pull request Dec 29, 2020
14 tasks
@krzys-h
Copy link
Member Author

krzys-h commented Dec 29, 2020

I added some basic tests for views which were not covered at all and set up coverage reporting (yay!)

@krzys-h
Copy link
Member Author

krzys-h commented Dec 29, 2020

The codecov GitHub Action does not support passing the -X html argument which is required to get the template coverage to show up, so use the offline report for that for now. See codecov/codecov-action#92

Copy link
Member

@cytadela8 cytadela8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 5 of 5 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, 2 of 2 files at r6.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@krzys-h krzys-h merged commit d298b72 into master Dec 30, 2020
@krzys-h krzys-h deleted the facepalm branch December 30, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants