OpenTofu support and JSON recentFile support #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update logic for reading sources for obtaining version to read from next source explicitly if version has not been set. This handles situations where a source exists (e.g. TOML file, terraform files), but a version constraint cannot be found from the source. This avoids duplicate checks for existance of sources (such as Terragrunt file), as this was performed in GetParamters and also in the methods to read the config from the source. Issue #420
…ParamsTOML also checks if the TOML file exists Issue #420
…sion, as these are handled directly from the GetVersionFromX methods Issue #420
…ic errors This was showing a warning as diagnostics from gohcl.DecodeBody was not used. Issue #420
…uations where no version is available when config files are present Issue #420
…form_version, as these are handled directly from the GetVersionFromX methods" This reverts commit 90433e0.
…arameters from them Issue #420
… overriding params Version with environment variable
…void polluting other tests
Previously, the highest priority was the TOML file, however, the new ordering means that terragrunt files have the highest precedence: #420
…suring each configuring overrides the previous
Refactor for creating files in precedence test and ensure files are cleaned up. Add test to ensure that command line argument for specifying version is handled as highest priority. Fix version matching, where they were incorrect in the tests
This is not needed, as the DefaultVersion is currently handled by main.go and not the parameter parsing This reverts commit 49fd706.
Closed
…easier testing Issue #315
…ng by new lines. Update uses of getTFURLBody to split, where necessary. Add tests to ensure parsing of hashicorp release page format works as expected Issue #315
Update release page parsing to iterate through all matches in the release page, rather than iterating through each line. This adds compatibility with the OpenTofu release page, which is all on one line. Issue #315
Make use of mock server to return example snippets from upstream release pages Issue #315
MatthewJohn
force-pushed
the
315-opentofu-support
branch
from
8fe6ee6
to
28d014e
Compare
…efault values Issue #315
…uired attributes for seperated functionality between Terraform and OpenTofu. Remove all hard coded defaults, moving to attributes of Product. Add new methods for handling "product" varients of public methods. Update previous public methods to call new methods, using Terraform product. Issue #315
MatthewJohn
force-pushed
the
315-opentofu-support
branch
2 times, most recently
from
f294651
to
565ad6e
Compare
MatthewJohn
force-pushed
the
315-opentofu-support
branch
from
565ad6e
to
f9d56fb
Compare
yermulnik
reviewed
Jun 5, 2024
yermulnik
approved these changes
Jun 5, 2024
|
@MatthewJohn I need to test a few more cases before merging. Will get it done by 12pm PST on Jun 6. |
@MatthewJohn @yermulnik please see remarks on #420 |
…is handled by the menu UI
…xistent slice index of recent file data
… in UI before appending all versions
warrensbox
reviewed
Jun 7, 2024
…ecking if the file exists was not being done in getRecentVersions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #315
#434